Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Burn fees for legacy transactions #5592

Merged
merged 1 commit into from
May 23, 2022

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented May 20, 2022

Motivation

Incorrect burnt fees and priority fees calculation for legacy transactions. Currently, fees from legacy transactions are not included into total burnt fees.

Changelog

Include legacy transactions into burnt fees
Change priority fees calculation, taking into account, that for legacy transactions:

transaction.max_priority_fee_per_gas = transaction.gas_price
transaction.max_fee_per_gas = transaction.gas_price

Checklist for your Pull Request (PR)

@vbaranov vbaranov requested a review from nikitosing May 20, 2022 12:19
@vbaranov vbaranov force-pushed the vb-burn-fess-for-legacy-transactions branch from b03dede to 7ea24ec Compare May 20, 2022 12:20
@vbaranov vbaranov force-pushed the vb-burn-fess-for-legacy-transactions branch from d01ffea to d5e0810 Compare May 23, 2022 20:40
@vbaranov vbaranov merged commit 8023005 into master May 23, 2022
@vbaranov vbaranov deleted the vb-burn-fess-for-legacy-transactions branch May 23, 2022 21:02
sidhujag pushed a commit to syscoin/blockscout that referenced this pull request May 29, 2022
…egacy-transactions

Burn fees for legacy transactions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants