Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contracts interaction: from networkID to chainID for chain detection #6028

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Sep 1, 2022

#5803

Motivation

Use CHAIN_ID env variable for comparison with wallet's chain ID on contract contract write page.

Checklist for your Pull Request (PR)

@vbaranov vbaranov force-pushed the vb-contract-interaction-network-id-to-chain-id branch from 046a072 to 06c464a Compare September 1, 2022 10:48
@vbaranov vbaranov changed the title Contracts interaction: networkID to chainID Contracts interaction: from networkID to chainID for chin detection Sep 1, 2022
@vbaranov vbaranov changed the title Contracts interaction: from networkID to chainID for chin detection Contracts interaction: from networkID to chainID for chain detection Sep 1, 2022
@vbaranov vbaranov merged commit 085bf68 into master Sep 1, 2022
@vbaranov vbaranov deleted the vb-contract-interaction-network-id-to-chain-id branch September 1, 2022 11:11
sidhujag pushed a commit to syscoin/blockscout that referenced this pull request Sep 2, 2022
rkachowski added a commit to celo-org/blockscout that referenced this pull request Sep 13, 2022
rkachowski added a commit to celo-org/blockscout that referenced this pull request Sep 13, 2022
rkachowski added a commit to celo-org/blockscout that referenced this pull request Sep 13, 2022
* Compare chain id correctly - blockscout#6028

* Add chain id and json rpc to app config on startup.

* Add sanctioned addresses.

* ESLint fix.

* Adjust pull request template.

* Checkout mix.exs lol.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant