Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unfetched token balances #6118

Merged
merged 2 commits into from
Sep 15, 2022
Merged

Fix unfetched token balances #6118

merged 2 commits into from
Sep 15, 2022

Conversation

Qwerty5Uiop
Copy link
Collaborator

Motivation

Condition in TokenBalance.unfetched_token_balances function will never be true for ERC-721 tokens, so Indexer.Fetcher.TokenBalance will always ignore them.

Changelog

Fixed condition so it works correctly for ERC-721 tokens.

@nikitosing nikitosing linked an issue Sep 15, 2022 that may be closed by this pull request
unfetched_token_balances ERC-721 balance update #5731
Closed
@vbaranov vbaranov merged commit 8a2b135 into master Sep 15, 2022
@vbaranov vbaranov deleted the fix-unfetched-token-balances branch September 15, 2022 13:10
@YARlabs YARlabs mentioned this pull request Nov 25, 2023
Open
@adamlaska adamlaska mentioned this pull request Nov 26, 2023
Open
@AliceSof AliceSof mentioned this pull request Nov 27, 2023
Open
@AkbarTrilaksana AkbarTrilaksana mentioned this pull request Nov 27, 2023
Open
@DSBUGAY2 DSBUGAY2 mentioned this pull request Nov 28, 2023
Open
@Abuchtela Abuchtela mentioned this pull request Nov 28, 2023
Open
@Jsn2win Jsn2win mentioned this pull request Dec 19, 2023
Open
@ZRDKPoWeR ZRDKPoWeR mentioned this pull request Dec 19, 2023
Open
@DSBUGAY2 DSBUGAY2 mentioned this pull request Dec 19, 2023
Open
@Abuchtela Abuchtela mentioned this pull request Dec 19, 2023
Open
@adamlaska adamlaska mentioned this pull request Dec 19, 2023
Open
@AkbarTrilaksana AkbarTrilaksana mentioned this pull request Dec 20, 2023
Open
@adamlaska adamlaska mentioned this pull request Dec 25, 2023
Open
@Woodpile37 Woodpile37 mentioned this pull request Feb 2, 2024
Merged
@adamlaska adamlaska mentioned this pull request Feb 2, 2024
Open
@AkbarTrilaksana AkbarTrilaksana mentioned this pull request Feb 2, 2024
Open
@Jsn2win Jsn2win mentioned this pull request Feb 2, 2024
Open
@Abuchtela Abuchtela mentioned this pull request Feb 3, 2024
Open
@ZRDKPoWeR ZRDKPoWeR mentioned this pull request Feb 3, 2024
Open
@DSBUGAY2 DSBUGAY2 mentioned this pull request Feb 3, 2024
Open
@Woodpile37 Woodpile37 mentioned this pull request Feb 5, 2024
Merged
@Woodpile37 Woodpile37 mentioned this pull request Feb 29, 2024
Open
@adamlaska adamlaska mentioned this pull request Mar 22, 2024
Open
@ZRDKPoWeR ZRDKPoWeR mentioned this pull request Mar 22, 2024
Open
@Woodpile37 Woodpile37 mentioned this pull request Mar 22, 2024
Open
@YARlabs YARlabs mentioned this pull request Mar 22, 2024
Open
@Jsn2win Jsn2win mentioned this pull request Mar 22, 2024
Open
@Nguyendinhtuan17 Nguyendinhtuan17 mentioned this pull request Mar 22, 2024
Merged
@0xE69 0xE69 mentioned this pull request Mar 22, 2024
Open
@DSBUGAY2 DSBUGAY2 mentioned this pull request Mar 22, 2024
Open
@AliceSof AliceSof mentioned this pull request Mar 22, 2024
Open
@AkbarTrilaksana AkbarTrilaksana mentioned this pull request Mar 22, 2024
Open
@Abuchtela Abuchtela mentioned this pull request Mar 23, 2024
Open
@Jircs1 Jircs1 mentioned this pull request Mar 23, 2024
Open
@DSBUGAY2 DSBUGAY2 mentioned this pull request Mar 24, 2024
Merged
@AkbarTrilaksana AkbarTrilaksana mentioned this pull request Mar 24, 2024
Open
@AliceSof AliceSof mentioned this pull request Mar 24, 2024
Open
@Jsn2win Jsn2win mentioned this pull request Mar 24, 2024
Open
@ZRDKPoWeR ZRDKPoWeR mentioned this pull request Mar 24, 2024
Open
@Woodpile37 Woodpile37 mentioned this pull request Mar 24, 2024
Open
@Jircs1 Jircs1 mentioned this pull request Mar 24, 2024
Open
@YARlabs YARlabs mentioned this pull request Mar 24, 2024
Open
@0xE69 0xE69 mentioned this pull request Mar 24, 2024
Open
@adamlaska adamlaska mentioned this pull request Mar 24, 2024
Open
@Abuchtela Abuchtela mentioned this pull request Mar 25, 2024
Open
@adamlaska adamlaska mentioned this pull request Mar 25, 2024
Open
This was referenced Mar 25, 2024
Open
Merged
@Woodpile37 Woodpile37 mentioned this pull request Mar 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbaranov vbaranov vbaranov approved these changes

@nikitosing nikitosing nikitosing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unfetched_token_balances ERC-721 balance update
3 participants
@Qwerty5Uiop @vbaranov @nikitosing