Update token balances in token instance fetcher #6168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qwerty5Uiop
force-pushed
the
improve-token-balances-updating
branch
from
eae813a
to
c3fb7b5
Compare
Qwerty5Uiop
force-pushed
the
improve-token-balances-updating
branch
from
c3fb7b5
to
96cbc16
Compare
vbaranov
reviewed
Sep 29, 2022
There was a problem hiding this comment.
Causing errors like this:
2022-09-29T15:48:29.844 [error] Task #PID<0.5732.0> started from Indexer.Fetcher.TokenInstance terminating
** (Postgrex.Error) ERROR 23503 (foreign_key_violation) insert or update on table "address_current_token_balances" violates foreign key constraint "address_current_token_balances_address_hash_fkey"
table: address_current_token_balances
constraint: address_current_token_balances_address_hash_fkey
Key (address_hash)=(\xacd934cc70048aa67656d445baadb7f5c0b8c582) is not present in table "addresses"
vbaranov
reviewed
Sep 29, 2022
| [ok_result] ++ acc | ||
|
|
||
| {:error, error_message} -> | ||
| Logger.error("Failed to get owner of token_id #{request.token_id}, reason: #{error_message}") |
There was a problem hiding this comment.
Could we also add token hash into the error for faster debugging?
vbaranov
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As an improvement of current token balances relevance, token instance fetcher can check info about token instance owner and update corresponding current token balance.
Changelog
Token instance fetcher now checks the owner of instance and update its current token balance.