Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transparent coin name definition #6183

Merged
merged 1 commit into from
Sep 28, 2022
Merged

Transparent coin name definition #6183

merged 1 commit into from
Sep 28, 2022

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Sep 28, 2022

Motivation

  • Obscure definition of the coin name (it isn't managed through a single env var)
  • unneeded storing of coin name in localization files in 2 different message ids.

Changelog

  • Remove coin name from localization files
  • define coin name it from COIN_NAME env var
  • remove COIN env var from build args of docker build
  • COIN env var -> EXCHANGE_RATES_COIN env vat (keep backward compatibility)

So, instead of having obscure COIN_NAME, COIN env vars and definitions of "Ether" and "ETH in .pot, .po files, the idea is to keep everything related to COIN in 2 env vars:
EXCHANGE_RATES_COIN - used by exchange rates fetching
COIN_NAME - display of coin name everywhere

Checklist for your Pull Request (PR)

@vbaranov vbaranov changed the title Remove coin name from localization files, defined it from COIN_NAME e… Transparent coin name definition Sep 28, 2022
@vbaranov vbaranov force-pushed the vb-fix-coin branch 4 times, most recently from e95bb5b to 4103d05 Compare September 28, 2022 18:34
…v var, remove COIN env var from build args, COIN -> EXCHANGE_RATES_COIN (add backward compatibility)
@vbaranov vbaranov merged commit baa727a into master Sep 28, 2022
@vbaranov vbaranov deleted the vb-fix-coin branch September 28, 2022 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant