Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix /blocks page freezing in case of large blocks numbers gaps #6243

Merged
merged 2 commits into from
Oct 11, 2022

Conversation

nikitosing
Copy link
Member

Close #5701

Motivation

In case of /blocks page recieves blocks from backend with a significant difference between min and max block numbers, page freezes and browser crashes. It happens because of withMissingBlocks function in apps/block_scout_web/assets/js/pages/blocks.js

Changelog

  • add limit on min and max block numbers difference

Checklist for your Pull Request (PR)

@runforesight
Copy link

runforesight bot commented Oct 11, 2022

Foresight Workflow Report

CodeQL workflow has finished in 1 minute 59 seconds and finished at 11th Oct, 2022. Conclusion: SUCCESS. Here is the analysis:


Job Failed Steps Tests Not tested changed lines*
Analyze (javascript) -     🔗  N/A N/A See Details

Blockscout workflow has finished in 27 minutes 37 seconds and finished at 11th Oct, 2022. Conclusion: SUCCESS. Here is the analysis:


Job Failed Steps Tests Not tested changed lines*
Build and Cache deps -     🔗  N/A N/A See Details
ESLint -     🔗  N/A N/A See Details
Code formatting checks -     🔗  N/A N/A See Details
Dialyzer static analysis -     🔗  N/A N/A See Details
Credo -     🔗  N/A N/A See Details
Missing translation keys check -     🔗  N/A N/A See Details
JS Tests -     🔗  N/A N/A See Details
Sobelow security analysis -     🔗  N/A N/A See Details
Blockscout Web Tests -     🔗  N/A N/A See Details
EthereumJSONRPC Tests -     🔗  N/A N/A See Details
Explorer Tests -     🔗  N/A N/A See Details
Indexer Tests -     🔗  N/A N/A See Details

*Not tested changed lines calculated for determining how much of the changes are covered by the tests.

@vbaranov vbaranov merged commit 0928ef4 into master Oct 11, 2022
@vbaranov vbaranov deleted the np-fix-freezing-blocks-page branch October 11, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove ETS caching from /blocks page
2 participants