Pending block operations update #6647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qwerty5Uiop
force-pushed
the
pending_block_operations_update
branch
2 times, most recently
from
cc30f4d
to
ed981c3
Compare
Qwerty5Uiop
force-pushed
the
pending_block_operations_update
branch
from
43949f9
to
7110521
Compare
vbaranov
approved these changes
Dec 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6561
Motivation
Currently we are fetching pending block operations block numbers via joining it with
blockstable and filtering by consensus. But there is no need to store non-consensus block info inpending_block_operationssince they are gonna be refetched anyway. Also, it's useful to add some denormalization topending_block_operationsso we don't need to join it with blocks and therefore there will be improvement of performance.Changelog
pending_block_operationsblock_numberfield topending_block_operations