Fix geth transaction tracer #6652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qwerty5Uiop
force-pushed
the
fix-js-tracer
branch
from
6abc378
to
82fd9ae
Compare
rude69
approved these changes
Dec 31, 2022
rude69
approved these changes
Dec 31, 2022
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
rude69
approved these changes
Jan 2, 2023
rude69
approved these changes
Jan 4, 2023
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Blockscout with this change: tracer errors still happen Blockscout with this change and geth with this fix: tracer errors still happen Blockscout unchanged and geth with this fix: different errors -- |
Qwerty5Uiop
force-pushed
the
fix-js-tracer
branch
from
82fd9ae
to
f852d64
Compare
vbaranov
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6638
Motivation
There is a similar issue and its solution in go-ethereum repo which are not yet included in any release, so we can apply this fix on our side for now.
Changelog
If the tracer tries to access memory beyond the available limit, we limit it to the end of the memory.