Add withdrawals support (EIP-4895) #6694

sl1depengwyn · 2023-01-10T10:35:52Z

Changelog

Add tab withdrawal to block page
Add tab withdrawal to address page
Add withdrawal fetcher (disabled by default because at the moment withdrawals is in the development, so withdrawals fetcher is not needed now at the majority of the chains)

Nodes for testing: https://github.com/ethpandaops/withdrawals-testnet/blob/master/withdrawal-devnet-3/inventory/inventory.ini (if down try to check withdrawal-devnet-n+1 or public net that going to be available soon)

Checklist for your Pull Request (PR)

I added an entry to CHANGELOG.md with this PR
If I added new functionality, I added tests covering it.
If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
I checked whether I should update the docs and did so by submitting a PR to https://github.com/blockscout/docs (Add envs and update sharelock for withdrawals docs#103)
If I added/changed/removed ENV var, I submitted a PR to https://github.com/blockscout/docs to update the list of env vars at https://github.com/blockscout/docs/blob/master/for-developers/information-and-settings/env-variables.md and I updated the version to master in the Version column. Changes will be reflected in this table: https://docs.blockscout.com/for-developers/information-and-settings/env-variables. (Add envs and update sharelock for withdrawals docs#103)
If I add new indices into DB, I checked, that they are not redundant with PGHero or other tools

vbaranov

@sl1depengwyn could you please add a screenshot(s) of UI changes for support of withdrawals feature to the description of PR?

sl1depengwyn · 2023-01-11T04:51:33Z

@sl1depengwyn could you please add a screenshot(s) of UI changes for support of withdrawals feature to the description of PR?

Done

nikitosing

Nitpick: let's leave just block number: 50197 instead of Block #50197 in Block column

nikitosing

Let's add pagination buttons to the bottom of address withdrawal list

apps/indexer/config/prod.exs

varasev · 2023-01-30T06:02:07Z

apps/indexer/lib/indexer/fetcher/withdrawal.ex

+    if reason === :normal do
+      {:noreply, state}
+    else
+      Logger.metadata(fetcher: :transaction_action)


Copy paste?

Yep, I'll fix it

Done in 1670e8f

nikitosing · 2023-01-30T09:55:24Z

apps/indexer/lib/indexer/fetcher/withdrawal.ex

+        select: block.number,
+        distinct: block.number,
+        where: block.number >= ^from,
+        where: is_nil(withdrawal.index)


consider to add here condition for block.consensus == true

Done in 1670e8f

sl1depengwyn · 2023-02-07T19:30:10Z

Let's add pagination buttons to the bottom of address withdrawal list

Nitpick: let's leave just block number: 50197 instead of Block #50197 in Block column

Done in 1670e8f

nikitosing · 2023-04-13T10:28:05Z

apps/explorer/lib/explorer/chain.ex

+  @spec check_if_withdrawals_in_block(Hash.Full.t()) :: boolean()
+  def check_if_withdrawals_in_block(block_hash) do
+    block_hash
+    |> Withdrawal.block_hash_to_withdrawals_query()


This is really micro improvment but nevertheless. Let's use here version of this query without order_by?

Make sense, fixed here bca0f23

nikitosing · 2023-04-13T10:28:16Z

apps/explorer/lib/explorer/chain.ex

+  @spec check_if_withdrawals_at_address(Hash.Address.t()) :: boolean()
+  def check_if_withdrawals_at_address(address_hash) do
+    address_hash
+    |> Withdrawal.address_hash_to_withdrawals_query()


The same as above

Make sense, fixed here bca0f23

nikitosing · 2023-04-13T10:35:48Z

apps/block_scout_web/lib/block_scout_web/views/withdrawal_view.ex

+  use BlockScoutWeb, :view
+
+  # import BlockScoutWeb.AddressView, only: [balance: 1]
+  # import BlockScoutWeb.Tokens.OverviewView, only: [total_supply_usd: 1]


Is it still needed?

Nope, thanks, fixed in bca0f23

nikitosing · 2023-04-13T10:42:00Z

apps/block_scout_web/lib/block_scout_web/controllers/api/v2/block_controller.ex

+         {:ok, block} <- fetch_block(type, value, @api_true) do
+      full_options =
+        [necessity_by_association: %{address: :optional}]
+        |> Keyword.merge(paging_options(params))


Needed to add api?: true here

Fixed in bca0f23

nikitosing · 2023-04-13T10:43:52Z

apps/block_scout_web/lib/block_scout_web/controllers/api/v2/address_controller.ex

+    with {:format, {:ok, address_hash}} <- {:format, Chain.string_to_address_hash(address_hash_string)},
+         {:ok, false} <- AccessHelper.restricted_access?(address_hash_string, params),
+         {:not_found, {:ok, _address}} <- {:not_found, Chain.hash_to_address(address_hash, @api_true, false)} do
+      withdrawals_plus_one = address_hash |> Chain.address_hash_to_withdrawals(paging_options(params))


Here also api?: true is missed

Fixed in bca0f23

nikitosing · 2023-04-13T10:47:07Z

apps/block_scout_web/lib/block_scout_web/controllers/api/v2/address_controller.ex

@@ -370,6 +370,22 @@ defmodule BlockScoutWeb.API.V2.AddressController do
    end
  end

+  def withdrawals(conn, %{"address_hash" => address_hash_string} = params) do


I think we need also add new field to address entity: has_beacon_chain_withdrawals to apps/block_scout_web/lib/block_scout_web/views/api/v2/address_view.ex:110 (Don't forget about api?: true)

The same applies to the block view, am I right?

yes but only for case when renders single block

Done in bca0f23

nikitosing · 2023-04-13T10:52:01Z

apps/indexer/lib/indexer/fetcher/withdrawal.ex

+    blocks
+  end
+
+  defp parse_integer(nil), do: nil


I think we can reuse parse_integer from apps/explorer/lib/explorer/helper.ex

Done in bca0f23

Add withdrawals to explorer app Add withdrawals to indexer Add withdrawal tabs to address and block pages Add withdrawals test to web Add withdrawals test to eth json rpc Add withdrawals test to explorer Add withdrawal test to indexer Update CHANGELOG.md Update gettext [no ci] Update apps/indexer/config/prod.exs [no ci] Co-authored-by: nikitosing <32202610+nikitosing@users.noreply.github.com> Fix review Update CHANGELOG.md Update CHANGELOG.md Add withdrawal list page; Add withdrawal to APIv2 Add timestamp Fix nikitosing review

sl1depengwyn force-pushed the mf-withdrawals branch 2 times, most recently from 9496ca4 to b8d39fd Compare January 10, 2023 11:04

sl1depengwyn mentioned this pull request Jan 10, 2023

Add envs and update sharelock for withdrawals blockscout/docs#103

Merged

sl1depengwyn force-pushed the mf-withdrawals branch from b8d39fd to ed4dbe6 Compare January 10, 2023 12:00

sl1depengwyn marked this pull request as ready for review January 10, 2023 12:04

sl1depengwyn requested review from vbaranov, nikitosing and Qwerty5Uiop January 10, 2023 12:04

vbaranov reviewed Jan 10, 2023

View reviewed changes

sl1depengwyn requested a review from vbaranov January 16, 2023 16:34

nikitosing reviewed Jan 29, 2023

View reviewed changes

apps/indexer/config/prod.exs Outdated Show resolved Hide resolved

varasev reviewed Jan 30, 2023

View reviewed changes

nikitosing reviewed Jan 30, 2023

View reviewed changes

sl1depengwyn force-pushed the mf-withdrawals branch 2 times, most recently from 896a520 to 1670e8f Compare February 7, 2023 19:23

sl1depengwyn force-pushed the mf-withdrawals branch 6 times, most recently from 9cb6ee5 to 8d753cc Compare April 12, 2023 05:06

sl1depengwyn requested review from nikitosing and vbaranov and removed request for vbaranov April 12, 2023 05:43

sl1depengwyn force-pushed the mf-withdrawals branch 2 times, most recently from b60f44b to fa09475 Compare April 13, 2023 09:22

sl1depengwyn force-pushed the mf-withdrawals branch 2 times, most recently from f526128 to b8c3052 Compare April 13, 2023 09:59

nikitosing reviewed Apr 13, 2023

View reviewed changes

sl1depengwyn force-pushed the mf-withdrawals branch 3 times, most recently from ca8e4f1 to 8e33fad Compare April 13, 2023 12:23

sl1depengwyn requested a review from nikitosing April 13, 2023 12:25

sl1depengwyn force-pushed the mf-withdrawals branch from 8e33fad to bca0f23 Compare April 13, 2023 12:38

vbaranov force-pushed the mf-withdrawals branch from bca0f23 to 288df0b Compare April 21, 2023 08:36

sl1depengwyn force-pushed the mf-withdrawals branch 3 times, most recently from a81018a to ded0cd5 Compare May 3, 2023 17:51

Add withdrawals counters

f44172d

sl1depengwyn force-pushed the mf-withdrawals branch from ded0cd5 to f44172d Compare May 3, 2023 17:52

Hide withdrawal item from navbar if disabled

8748e5d

vbaranov approved these changes May 4, 2023

View reviewed changes

vbaranov merged commit 9615e2f into master May 4, 2023
1 check passed

vbaranov deleted the mf-withdrawals branch May 4, 2023 08:52

vbaranov had a problem deploying to Tests May 4, 2023 09:02 — with GitHub Actions Failure

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add withdrawals support (EIP-4895) #6694

Add withdrawals support (EIP-4895) #6694

sl1depengwyn commented Jan 10, 2023 •

edited

Loading

vbaranov left a comment

sl1depengwyn commented Jan 11, 2023

nikitosing left a comment

nikitosing left a comment

varasev Jan 30, 2023

sl1depengwyn Jan 30, 2023 •

edited

Loading

sl1depengwyn Feb 7, 2023

nikitosing Jan 30, 2023

sl1depengwyn Feb 7, 2023

sl1depengwyn commented Feb 7, 2023

nikitosing Apr 13, 2023

sl1depengwyn Apr 13, 2023 •

edited

Loading

nikitosing Apr 13, 2023

sl1depengwyn Apr 13, 2023 •

edited

Loading

nikitosing Apr 13, 2023

sl1depengwyn Apr 13, 2023 •

edited

Loading

nikitosing Apr 13, 2023

sl1depengwyn Apr 13, 2023 •

edited

Loading

nikitosing Apr 13, 2023

sl1depengwyn Apr 13, 2023 •

edited

Loading

nikitosing Apr 13, 2023

sl1depengwyn Apr 13, 2023

nikitosing Apr 13, 2023

sl1depengwyn Apr 13, 2023 •

edited

Loading

nikitosing Apr 13, 2023

sl1depengwyn Apr 13, 2023 •

edited

Loading

Add withdrawals support (EIP-4895) #6694

Add withdrawals support (EIP-4895) #6694

Conversation

sl1depengwyn commented Jan 10, 2023 • edited Loading

Changelog

Checklist for your Pull Request (PR)

vbaranov left a comment

Choose a reason for hiding this comment

sl1depengwyn commented Jan 11, 2023

nikitosing left a comment

Choose a reason for hiding this comment

nikitosing left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sl1depengwyn Jan 30, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sl1depengwyn commented Feb 7, 2023

Choose a reason for hiding this comment

sl1depengwyn Apr 13, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sl1depengwyn Apr 13, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sl1depengwyn Apr 13, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sl1depengwyn Apr 13, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sl1depengwyn Apr 13, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sl1depengwyn Apr 13, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sl1depengwyn Apr 13, 2023 • edited Loading

Choose a reason for hiding this comment

sl1depengwyn commented Jan 10, 2023 •

edited

Loading

sl1depengwyn Jan 30, 2023 •

edited

Loading

sl1depengwyn Apr 13, 2023 •

edited

Loading

sl1depengwyn Apr 13, 2023 •

edited

Loading

sl1depengwyn Apr 13, 2023 •

edited

Loading

sl1depengwyn Apr 13, 2023 •

edited

Loading

sl1depengwyn Apr 13, 2023 •

edited

Loading

sl1depengwyn Apr 13, 2023 •

edited

Loading

sl1depengwyn Apr 13, 2023 •

edited

Loading