Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API v2: new methods #6712

Merged
merged 11 commits into from
Jan 17, 2023
Merged

API v2: new methods #6712

merged 11 commits into from
Jan 17, 2023

Conversation

nikitosing
Copy link
Member

@nikitosing nikitosing commented Jan 12, 2023

Motivation

Changelog

  • Add /search/check-redirect
  • Add type query parameter to /tokens in order to filter by token type
  • Add /addresses/{address_hash}/token-transfers?token={token_address_hash}
  • Add method, block_hash and log_index fields to token transfers
  • Add tx_hash field to logs
  • Add coin_balance to address in /addresses

Checklist for your Pull Request (PR)

@nikitosing nikitosing mentioned this pull request Jan 15, 2023
31 tasks
@nikitosing nikitosing changed the title Add /search/check-redirect API v2: new methods Jan 15, 2023
Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikitosing

get api/v2/search/check-redirect responds with

Phoenix.ActionClauseError at GET /api/v2/search/check-redirect
no function clause matching in BlockScoutWeb.API.V2.SearchController.check_redirect/2
The following arguments were given to BlockScoutWeb.API.V2.SearchController.check_redirect/2:

    # 1
    %Plug.Conn{adapter: {Plug.Cowboy.Conn, :...}, assigns: %{}, body_params: %{}, cookies: %
...

Is this expected?

@nikitosing
Copy link
Member Author

@vbaranov Yes, in such a case back-end sends 400 response, this is expected

@vbaranov vbaranov self-requested a review January 17, 2023 10:05
@vbaranov
Copy link
Member

@vbaranov Yes, in such a case back-end sends 400 response, this is expected

Which type of call will be successful?

@nikitosing
Copy link
Member Author

@vbaranov /api/v2/search/check-redirect?q=0x0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants