Support basic auth in JSON RPC endpoint #6897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbaranov
force-pushed
the
vb-basic-auth
branch
from
51120c9
to
c064682
Compare
vbaranov
force-pushed
the
vb-basic-auth
branch
from
c064682
to
6fceab0
Compare
nikitosing
reviewed
Feb 16, 2023
nikitosing
reviewed
Feb 16, 2023
| end | ||
| [pool: :ethereum_jsonrpc] | ||
| |> (&if(System.get_env("ETHEREUM_JSONRPC_HTTP_INSECURE", "") == "true", do: [:insecure] ++ &1, else: &1)).() | ||
| |> (&if(basic_auth_user != "" && basic_auth_pass != "", |
There was a problem hiding this comment.
What if password is empty string?
There was a problem hiding this comment.
Does it make sense to enable Basic auth on RPC endpoint with blank password? I think it is very unlikely case.
There was a problem hiding this comment.
It is valid. Implemented in 3b5dc3d.
nikitosing
approved these changes
Feb 16, 2023
sl1depengwyn
force-pushed
the
vb-basic-auth
branch
from
f7476e8
to
b4365fd
Compare
fx0x55
pushed a commit
to FunctionX/blockscout
that referenced
this pull request
May 10, 2023
* Support basic auth in JSON RPC endpoint * Review comment: Allow blank password in basi auth of JSON RPC endpoint * Reuse basic auth configuration function --------- Co-authored-by: sl1depengwyn <max.pengwyn@gmail.com> (cherry picked from commit 65d7ad5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3501
Motivation
Blockscout doesn't support JSON RPC endpoints with basic auth.
Changelog
Support basic auth in JSON RPC endpoints by adding hackney params:
[basic_auth: {"user", "pass"}].ETHEREUM_JSONRPC_USERandETHEREUM_JSONRPC_PASSWORDare for basic auth management.Docs update in blockscout/docs#114.
Checklist for your Pull Request (PR)
CHANGELOG.mdwith this PRmasterin the Version column. Changes will be reflected in this table: https://docs.blockscout.com/for-developers/information-and-settings/env-variables.