Fix WebSocketClient #6922
Merged
Fix WebSocketClient #6922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qwerty5Uiop
force-pushed
the
fix-websocket-client
branch
from
2512060
to
be73dae
Compare
vbaranov
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6800
Resolves #6886
Resolves #6914
Motivation
websocket_client v1.5.0 does not support
GenServer.call, soWebSocketClientimplementation becomes incorrect with this lib versionChangelog
Replaced websocket_client source with forked and fixed one, adapted
WebSocketClientto this fixRelated commit in forked Websocket client is blockscout/websocket_client@0b4ecc5.