Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend INDEXER_MEMORY_LIMIT env parsing #6929

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

sl1depengwyn
Copy link
Collaborator

@sl1depengwyn sl1depengwyn commented Feb 17, 2023

Motivation

It's not obvious that value of INDEXER_MEMORY_LIMIT must be a single number (https://discord.com/channels/973915550965174292/992040622254997566/1072857553622540399)

Changelog

Added possibility to set INDEXER_MEMORY_LIMIT with suffixes like gb, g, mb, m independently of letter case. With no suffix interpreted as gb as it was.

Checklist for your Pull Request (PR)

@sl1depengwyn sl1depengwyn force-pushed the mf-extend-INDEXER_MEMORY_LIMIT-env-parsing branch from dc7f1f6 to 7e3756f Compare February 17, 2023 18:02
@sl1depengwyn sl1depengwyn force-pushed the mf-extend-INDEXER_MEMORY_LIMIT-env-parsing branch from 7e3756f to 80fa295 Compare February 17, 2023 18:09
@sl1depengwyn sl1depengwyn marked this pull request as ready for review February 17, 2023 18:59
Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sl1depengwyn
Copy link
Collaborator Author

I suppose related doc page should be updated as well https://docs.blockscout.com/for-developers/indexing/how-do-i-update-memory-consumption-to-fix-indexer-memory-errors

Here it is: blockscout/docs#119
Thank you!

@vbaranov vbaranov self-requested a review February 21, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants