Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some compile time vars to runtime #6954

Merged
merged 1 commit into from
Feb 23, 2023
Merged

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Feb 22, 2023

Resolves #6310

Motivation

NETWORK_PATH env variable is compile-time variable.

Changelog

NETWORK_PATH can be changed in runtime now.

Chore:

  • removing of SOCKET_ROOT, API_PATH env variables (both are managed through NETWORK_PATH now)
  • DISABLE_BRIDGE_MARKET_CAP_UPDATER, CACHE_BRIDGE_MARKET_CAP_UPDATE_INTERVAL are removed from CI as not used in the application.
    Docs update in NETWORK_PATH in runtime docs#121

Checklist for your Pull Request (PR)

@vbaranov vbaranov force-pushed the vb-remove-compile-time-vars branch 5 times, most recently from e81f44b to 0998ac2 Compare February 23, 2023 09:35
@vbaranov vbaranov changed the title Remove compile time vars Move some compile time vars to runtime Feb 23, 2023
@vbaranov vbaranov merged commit e8b55af into master Feb 23, 2023
@vbaranov vbaranov deleted the vb-remove-compile-time-vars branch February 23, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENV NETWORK_PATH doesn't work.
1 participant