Bedrock optimism deposits

[sl1depengwyn]

No description provided.

[varasev]

Please, view my comments, especially about the method of getting logs (events) and getting blocks timestamps by their numbers. I'm worried of using eth_newFilter and eth_getFilterChanges - not sure they will work in production.

[varasev]

Let's add logging to handle_new_logs when logs_to_parse list is not empty. I would do that as follows:

Optimism.log_blocks_chunk_handling(start_block, end_block, start_block, end_block, "#{Enum.count(logs_to_parse)} TransactionDeposited event(s)", "L1")

Here start_block is the min number of block found in blockNumber field of the RPC response, end_block is the max number of block found in blockNumber field of the RPC response.

Could you please clarify why we need one more message for the same action, we already have messages like this:

2023-03-16T11:24:36.867 application=indexer fetcher=optimism_deposits [info] Finish handling L1 block range 8552936..8553436. Found 111 TransactionDeposited event(s). Target range: 8381594..8663789. Progress: 60.89%

here we see how many events are in the range

This is for realtime mode logging. We still don't have logs for realtime

[varasev]

There are two things left to do before merging:

1. Bedrock optimism deposits #6993 (comment)

2. Bedrock optimism deposits #6993 (comment)

[sl1depengwyn]

There are two things left to do before merging:

1. #6993 (comment)
2. #6993 (comment)

Done here 1392710

About case when from_block > to_block:
I decided to check it in init function and switch to realtime immediately if it is the case