Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend token instance metadata parsing functionality #7031

Merged
merged 1 commit into from Mar 6, 2023

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Mar 6, 2023

Motivation

Multiple token instance metadata fetching errors

Changelog

New fetching token instances covered:

  • parse IPFS links, if protocol is in diverse case (IPFS://, IpFs:// etc)
  • fetch URI, if token URI directly passed to fetch_json/2
  • fetch URI, if token URI in quotes directly passed to fetch_json/2
  • fetch URI, if CIDv0 IPFS id directly passed to fetch_json/2
  • process an error, if whatever response code returned, but error message contains execution reverted text
  • process an error, if whatever response code returned, but error message contains VM execution error text

Checklist for your Pull Request (PR)

@vbaranov vbaranov force-pushed the vb-extend-token-instance-metadata-parsing branch 2 times, most recently from 0b89170 to 64082b7 Compare March 6, 2023 19:44
@vbaranov vbaranov force-pushed the vb-extend-token-instance-metadata-parsing branch from 64082b7 to 67ead3f Compare March 6, 2023 19:47
@vbaranov vbaranov merged commit 49afe79 into master Mar 6, 2023
@vbaranov vbaranov deleted the vb-extend-token-instance-metadata-parsing branch March 6, 2023 20:00
@vbaranov vbaranov mentioned this pull request Mar 9, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant