Set updated_at on token update even if there are no changes #7055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qwerty5Uiop
force-pushed
the
decrease-eth-call-calls
branch
from
078048d
to
689733b
Compare
vbaranov
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently,
Indexer.Fetcher.TokenUpdatercollects tokens to be updated based onupdated_atfield. But if there are no actual changes for token, such an 'empty' update doesn't affect theupdated_atfield, which means that this token will be recognised as not updated on the next check and, therefore, there will be additionaleth_calls even if this token was checked recently.Changelog
Set
updated_atfield manually onExplorer.Chain.update_token/2so empty updates will be 'stored' inupdated_atfield.