-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor runtime config #7119
Refactor runtime config #7119
Conversation
8625fad
to
a2271c5
Compare
75c82c6
to
adc7162
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be replaced with parse_time_env_var
?
Also in some places we explicitly set nil
as default value for System.get_env
but in majority of cases we leave it as a default argument, I suggest to stick to one solution for consistency and either remove explicit nil
s or add them everywhere
2f64759
to
c76e8e1
Compare
523e6ed
to
6ca3e3e
Compare
877ead9
to
bbcecf5
Compare
bbcecf5
to
1522ce4
Compare
* Refactor runtime config * Process reviewer comments * Invalidate GA cache (cherry picked from commit c6decf3)
Motivation
A lot of patterns in runtime config
Changelog
Define common functions to parse integer, time and boolean env variables from runtime config.
Docs update in blockscout/docs#128
Chore: Rename all "helpers" modules to singular ("helper").
Checklist for your Pull Request (PR)
CHANGELOG.md
with this PRmaster
in the Version column. Changes will be reflected in this table: https://docs.blockscout.com/for-developers/information-and-settings/env-variables.