New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split token instance fetcher #7286
Conversation
12c76a1
to
eb6f08e
Compare
eb6f08e
to
745fec3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest changing the folders structure and naming of new fetcher's for consistency and reading convenience purposes. Here is the suggestion how to rename new fetchers:
Indexer.Fetcher.Realtime.TokenInstance -> Indexer.Fetcher.TokenInstance.Realtime
Indexer.Fetcher.Retry.TokenInstance -> Indexer.Fetcher.TokenInstance.Retry
Indexer.Fetcher.Sanitize.TokenInstance -> Indexer.Fetcher.TokenInstance.Sanitize
Indexer.Fetcher.TokenInstance -> Indexer.Fetcher.TokenInstance.Helper
And the folder structure like this:
apps/indexer/lib/indexer/fetcher/token_instance:
- realtime.ex
- retry.ex
- sanitize.ex
- helper.ex
apps/explorer/lib/explorer/token/instance_metadata_retriever.ex
Outdated
Show resolved
Hide resolved
98862a3
to
7ea1863
Compare
Close #7024
Changelog
Now 3 fetchers are responsible for fetching token instances:
Realtime
fetcher:token_instances
table came fromBlock.Fetcher
stoken_instances
table. If not then also added but with someerror
Retry
fetcher:SELECT * FROM token_instances WHERE error IS NOT NULL
Sanitize
fetcher:token_instances
table. If not then also added but with someerror
Remove:
INDEXER_TOKEN_INSTANCE_BATCH_SIZE
INDEXER_TOKEN_INSTANCE_CONCURRENCY
Add:
INDEXER_TOKEN_INSTANCE_RETRY_REFETCH_INTERVAL
INDEXER_TOKEN_INSTANCE_RETRY_CONCURRENCY
INDEXER_TOKEN_INSTANCE_REALTIME_CONCURRENCY
INDEXER_TOKEN_INSTANCE_SANITIZE_CONCURRENCY
blockscout/docs#141
Checklist for your Pull Request (PR)
CHANGELOG.md
with this PRmaster
in the Version column. Changes will be reflected in this table: https://docs.blockscout.com/for-developers/information-and-settings/env-variables.