Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account: derive Auth0 logout urls from existing envs #7337

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Apr 25, 2023

Motivation

Currently, in order to setup Account functionality, Blockscout requires:

export ACCOUNT_AUTH0_LOGOUT_URL=https://auth0_domain/v2/logout
export ACCOUNT_AUTH0_LOGOUT_RETURN_URL=explorer_protocol://explorer_host:explorer_port/explorer_path/auth/logout

to be set.

However,

  • we already defined auth0_domain in ACCOUNT_AUTH0_DOMAIN
  • explorer_protocol://explorer_host:explorer_port/explorer_path is already can be constructed via BlockScoutWeb.APIDocsView.blockscout_url() function.

Changelog

Remove redundant

  • ACCOUNT_AUTH0_LOGOUT_URL
  • ACCOUNT_AUTH0_LOGOUT_RETURN_URL
    environment variables.

Docs update in blockscout/docs#144.
Frontend deployments update blockscout/frontend#785.
Deployment values update https://github.com/blockscout/deployment-values/pull/38.

Checklist for your Pull Request (PR)

@vbaranov vbaranov merged commit 6f40a4a into master Apr 25, 2023
@vbaranov vbaranov deleted the vb-simplify-account-setup branch April 25, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants