Realtime fetcher max gap #7393
Merged
Realtime fetcher max gap #7393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qwerty5Uiop
force-pushed
the
realtime-fetcher-max-gap
branch
from
79da859
to
cc93a31
Compare
vbaranov
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There may be cases where a node may return inconsistent data. In such cases, the fetcher will treat the difference in the latest blocks as a real break in the data, which can cause it to do a huge amount of unnecessary work.
Changelog
Added
max_gapparameter to realtime fetcher which may be modified viaINDEXER_REALTIME_FETCHER_MAX_GAPenv var. This parameter will be used as a max meaningful gap between consecutive latest blocks. If previous latest block differs from current by more thanmax_gap, the max value will be selected as a real latest number.Docs update in blockscout/docs#149