Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shrinking logo in safari #7516

Merged
merged 1 commit into from
May 23, 2023
Merged

Fix shrinking logo in safari #7516

merged 1 commit into from
May 23, 2023

Conversation

sl1depengwyn
Copy link
Collaborator

@sl1depengwyn sl1depengwyn commented May 19, 2023

Part of #6437

Motivation

.png images were shrinking in Safari browser

Changelog

Changed default width value for logo from 100% to auto

before:
image
after:
image

Checklist for your Pull Request (PR)

@sl1depengwyn sl1depengwyn marked this pull request as ready for review May 19, 2023 13:54
@@ -251,7 +251,6 @@ $header-logo-text-color: #333 !default;

.navbar-logo {
max-height: $navbar-logo-height;
width: $navbar-logo-width;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This parameter could be defined for some client setups. Probably, we could keep its usage, but change the default 100% to auto?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, fixed

@vbaranov vbaranov merged commit 1b22941 into master May 23, 2023
18 checks passed
@vbaranov vbaranov deleted the mf-fix-shrinkng-logo branch May 23, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants