Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tokens pagination #7611

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Fix tokens pagination #7611

merged 1 commit into from
Jun 5, 2023

Conversation

sl1depengwyn
Copy link
Collaborator

@sl1depengwyn sl1depengwyn commented Jun 1, 2023

Motivation

  • Pagination fails in case of null or the same token names, holders and market cap
  • Nullable fields are not handled correctly

Changelog

  • Add token contract address hash to pagination key for uniqueness
  • Handle each nullable field individually
  • Add circulating_market_cap field to /api/v2/tokens/ response

Checklist for your Pull Request (PR)

@sl1depengwyn sl1depengwyn force-pushed the mf-fix-tokens-pagination branch 3 times, most recently from 517269a to 5559fb3 Compare June 1, 2023 21:21
@sl1depengwyn sl1depengwyn requested review from vbaranov and nikitosing and removed request for vbaranov June 1, 2023 21:32
@sl1depengwyn sl1depengwyn marked this pull request as ready for review June 1, 2023 21:33
@sl1depengwyn sl1depengwyn marked this pull request as draft June 2, 2023 09:35
@sl1depengwyn sl1depengwyn marked this pull request as ready for review June 4, 2023 11:55
@vbaranov vbaranov merged commit 2db2813 into master Jun 5, 2023
15 checks passed
@vbaranov vbaranov deleted the mf-fix-tokens-pagination branch June 5, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants