Filter addresses before insertion #7811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qwerty5Uiop
force-pushed
the
filter-addresses-before-insertion
branch
3 times, most recently
from
b52d25e
to
3269246
Compare
nikitosing
reviewed
Jun 30, 2023
Qwerty5Uiop
force-pushed
the
filter-addresses-before-insertion
branch
from
3269246
to
928007e
Compare
nikitosing
approved these changes
Jul 1, 2023
vbaranov
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In cases when there are addresses that appears in many blocks, we have a large amount of blocking insert queries when in fact only small part of them will pass the
on conflictcondition. It makes sense to filter them on the app side first selecting them from db. These operations will not block each other.Changelog
Add addresses filtration before insertion.