Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API v2: Add sorting to tokens page #7895

Merged
merged 1 commit into from
Jul 18, 2023
Merged

API v2: Add sorting to tokens page #7895

merged 1 commit into from
Jul 18, 2023

Conversation

sl1depengwyn
Copy link
Collaborator

@sl1depengwyn sl1depengwyn commented Jul 10, 2023

Part of #7794

Changelog

Added two new query parameters for api/v2/tokens endpoint

  • sort - possible values: fiat_value, holder_count, circulating_market_cap
  • order - possible values: asc, desc

Added fiat_value to next_page_params to be able to sort by fiat_value, note that it should not break the new UI

This PR can be tested in the old ui on the https://github.com/blockscout/blockscout/tree/mf-add-tokens-sorting-test branch by adding these new query parameters by hand

Checklist for your Pull Request (PR)

@sl1depengwyn sl1depengwyn force-pushed the mf-add-tokens-sorting branch 2 times, most recently from 5b56332 to 8ccb22a Compare July 10, 2023 12:04
@sl1depengwyn sl1depengwyn marked this pull request as ready for review July 10, 2023 12:15
@vbaranov vbaranov merged commit 8f062e6 into master Jul 18, 2023
15 checks passed
@vbaranov vbaranov deleted the mf-add-tokens-sorting branch July 18, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants