Delete token balances only for blocks that lost consensus #7927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qwerty5Uiop
force-pushed
the
delete-token-balances-for-non-consensus-blocks
branch
from
3291a6f
to
6588733
Compare
nikitosing
approved these changes
Jul 18, 2023
Qwerty5Uiop
force-pushed
the
delete-token-balances-for-non-consensus-blocks
branch
from
0fa0cdc
to
5975421
Compare
sl1depengwyn
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently we delete token balances on block import for every consensus block but it's needed only for reorgs so it's reasonable to delete balances only for blocks that lost consensus.
Changelog
Changed blocks runner to delete token balances only for blocks that lost consensus