Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate /api/v2/bytecodes/sources:search-all of eth_bytecode_db #8472

Merged
merged 1 commit into from Oct 10, 2023

Conversation

nikitosing
Copy link
Member

@nikitosing nikitosing commented Sep 17, 2023

Close #8291
Close #8449

Changelog

  • Now async call to ETH Bytecode DB performs to /api/v2/bytecodes/sources:search-all endpoint if on the instance set CHAIN_ID
  • Refactoring of check_and_verify in PublishHelper
  • Now Explorer.Chain.Fetcher.LookUpSmartContractSourcesOnDemand has concurrency managed by MICROSERVICE_ETH_BYTECODE_DB_MAX_LOOKUPS_CONCURRENCY (default is 10)
    Add MICROSERVICE_ETH_BYTECODE_DB_MAX_LOOKUPS_CONCURRENCY docs#180

Checklist for your Pull Request (PR)

Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase, add spec and doc for all new public functions, squash into one commit.

apps/explorer/lib/explorer/chain.ex Outdated Show resolved Hide resolved
@nikitosing nikitosing force-pushed the np-eth-bytecode-db-new-endpoint branch from 21dd5e3 to 4fed453 Compare October 5, 2023 19:09
@vbaranov vbaranov merged commit 69abff0 into master Oct 10, 2023
15 checks passed
@vbaranov vbaranov deleted the np-eth-bytecode-db-new-endpoint branch October 10, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants