Set poll: false for internal transactions fetcher #8965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qwerty5Uiop
force-pushed
the
ap-set-poll-false-for-int-trans-fetcher
branch
from
5c0ad31
to
6177c53
Compare
Qwerty5Uiop
requested review from
vbaranov,
nikitosing,
varasev and
sl1depengwyn
vbaranov
reviewed
Dec 11, 2023
There was a problem hiding this comment.
@Qwerty5Uiop could we create a regression test for this case?
Qwerty5Uiop
force-pushed
the
ap-set-poll-false-for-int-trans-fetcher
branch
from
6177c53
to
8a72e5e
Compare
vbaranov
approved these changes
Dec 18, 2023
Qwerty5Uiop
force-pushed
the
ap-set-poll-false-for-int-trans-fetcher
branch
2 times, most recently
from
040ec16
to
5867510
Compare
sl1depengwyn
approved these changes
Dec 21, 2023
vbaranov
force-pushed
the
ap-set-poll-false-for-int-trans-fetcher
branch
from
5867510
to
a02b3ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
PendingBlockOperations are filled along with blocks (in the same import stage), but transactions are imported in the next stage which means in different db transaction. So there is a time range when pbo already exists in db but transactions doesn't. If internal transactions fetcher starts processing in this time range, pbo will be deleted but internal transactions won't be inserted since their parent transactions doesn't exist.
Changelog
Turn off internal transactions fetcher periodical
initrerun, so it will start processing only after manual call from block fetchers