Don't fetch first trace for pending transactions #9253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qwerty5Uiop
force-pushed
the
ap-dont-fetch-first-trace-for-pending-trans
branch
from
9c9c683
to
9cdbe48
Compare
Qwerty5Uiop
requested review from
vbaranov,
nikitosing,
varasev and
sl1depengwyn
vbaranov
approved these changes
Jan 25, 2024
nikitosing
approved these changes
Jan 25, 2024
vbaranov
force-pushed
the
ap-dont-fetch-first-trace-for-pending-trans
branch
from
9cdbe48
to
bef38a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fetching first trace for pending transaction is meaningless and causes minor bugs.
Changelog
Check if transaction is pending before fetching its first trace