Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation name behind proxy name #1798

Closed
NikitaSavik opened this issue Apr 9, 2024 · 4 comments · Fixed by #2071
Closed

Implementation name behind proxy name #1798

NikitaSavik opened this issue Apr 9, 2024 · 4 comments · Fixed by #2071
Assignees
@tom2drum
Labels
v1.33.0 Release v1.33.0

Comments

@NikitaSavik
Copy link
Contributor

Design
@NikitaSavik NikitaSavik added the need design For issues that wait for design updates label Apr 9, 2024
@tgladilina
Copy link
Collaborator

FIgma

Sample of tooltip behavior on hover https://dappradar.com/rankings/games

Image

@tgladilina tgladilina removed the need design For issues that wait for design updates label Apr 18, 2024
@NikitaSavik
Copy link
Contributor Author

NikitaSavik commented Apr 25, 2024 •
edited

  • Implementation has name: show implementation name (on click go to proxy in any case)
  • Otherwise show proxy name / hash
  • 'copy' button should copy proxy address
  • green 'link' icon should indicate that both implementation and proxy are verified

@tom2drum tom2drum self-assigned this May 20, 2024
@tom2drum tom2drum changed the title Implementation name bhind proxy name Implementation name behind proxy name May 20, 2024
@tom2drum tom2drum mentioned this issue May 21, 2024
Closed
@tom2drum tom2drum added the need API For issues that wait for API changes label May 21, 2024
@tom2drum
Copy link
Collaborator

@tgladilina we need to adjust the tooltip mockup and showcase the case with multiple implementations. Each implementation has an address hash and an optional name. The actual number of implementations can be significant (e.g., 10 or even more).

Tooltip

Image

Example #1

@tom2drum tom2drum added the need design For issues that wait for design updates label May 29, 2024
@tom2drum tom2drum mentioned this issue May 29, 2024
Closed
@tgladilina
Copy link
Collaborator

tgladilina commented May 31, 2024 •
edited

@NikitaSavik @tom2drum mockup

Image

@tgladilina tgladilina removed the need design For issues that wait for design updates label May 31, 2024
@tom2drum tom2drum removed the need API For issues that wait for API changes label Jul 3, 2024
@tom2drum tom2drum mentioned this issue Jul 3, 2024
Merged
4 tasks
@github-actions github-actions bot added pre-release Tasks in pre-release right now v1.33.0 Release v1.33.0 and removed pre-release Tasks in pre-release right now labels Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tom2drum tom2drum

Labels
v1.33.0 Release v1.33.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implementation name behind proxy name blockscout/frontend
3 participants
@NikitaSavik @tom2drum @tgladilina