Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marketplace banner #1785

Merged
merged 16 commits into from
Apr 15, 2024
Merged

Marketplace banner #1785

merged 16 commits into from
Apr 15, 2024

Conversation

maxaleks
Copy link
Collaborator

@maxaleks maxaleks commented Apr 4, 2024

Description and Related Issue(s)

Resolves #1646

Introduced new env vars:

  1. NEXT_PUBLIC_MARKETPLACE_FEATURED_APP
  2. NEXT_PUBLIC_MARKETPLACE_BANNER_CONTENT_URL
  3. NEXT_PUBLIC_MARKETPLACE_BANNER_LINK_URL

Checklist for PR author

  • I have tested these changes locally.
  • I added tests to cover any new functionality, following this guide
  • Whenever I fix a bug, I include a regression test to ensure that the bug does not reappear silently.
  • If I have added, changed, renamed, or removed an environment variable, I have updated the list of environment variables in the documentation and made the necessary changes to the validator script according to the guide

Copy link
Collaborator

@tom2drum tom2drum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please add some tests to cover new functionality
  2. Also, please mention changes in the ENV variables in Pull request description

There should be a checklist for the author to ensure these tasks are not forgotten when creating a pull request.

ui/marketplace/Banner.tsx Outdated Show resolved Hide resolved
ui/marketplace/Banner.tsx Outdated Show resolved Hide resolved
configs/app/features/marketplace.ts Show resolved Hide resolved
@maxaleks maxaleks merged commit f95bb0f into main Apr 15, 2024
14 checks passed
@maxaleks maxaleks deleted the marketplace-banner branch April 15, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markeplace banner
2 participants