Skip to content
This repository has been archived by the owner on Jan 6, 2023. It is now read-only.

Provide input for collecting repository URL in App Mining registration form #259

Closed
markmhendrickson opened this issue Oct 15, 2018 · 4 comments
Assignees

Comments

@markmhendrickson
Copy link
Contributor

markmhendrickson commented Oct 15, 2018

A new input for "Public repository" should appear when the user selects "Yes" for "Does your app have Blockstack Auth implemented?" in the App Mining registration form upon selecting "Register for App Mining" on https://app.co/mining.

This input should be displayed below the above prompt and above the "Submit" button. Its placeholder text should be "https://github.com/developer/app". The field should be optional and the value entered should be stored alongside the rest of the registration data in our database.

screen shot 2018-10-15 at 11 50 50

Requested by @xanbots

@markmhendrickson markmhendrickson added this to Needs design in Launch App Mining via automation Oct 15, 2018
@markmhendrickson markmhendrickson moved this from Needs design to Needs development in Launch App Mining Oct 15, 2018
@aulneau aulneau moved this from Needs development to In progress in Launch App Mining Oct 15, 2018
@aulneau
Copy link
Contributor

aulneau commented Oct 16, 2018

@hstove I've added this to the frontend as an optional field. the key I chose is repo

@aulneau
Copy link
Contributor

aulneau commented Oct 16, 2018

screen shot 2018-10-16 at 12 33 28 pm

@markmhx I've opted to keep the input above the radio buttons as it felt out of place. I also think a placeholder of Public Repository (GitHub, etc)* makes more sense and is consistent with how we are using our other labels as placeholders. If you have a larger rational for either choice please let me know!

@hstove hstove moved this from In progress to Needs review in Launch App Mining Oct 17, 2018
@markmhendrickson
Copy link
Contributor Author

@aulneau Those are good improvements 👍🏻

As a result, though, we should probably just show the public repository input regardless of whether the user toggles "Yes" for the Blockstack Auth prompt, since it would be strange to reveal an input above that prompt.

@aulneau
Copy link
Contributor

aulneau commented Oct 17, 2018

Yep! That's how it currently functions

@markmhendrickson markmhendrickson moved this from Needs review to Reviewer approved in Launch App Mining Oct 17, 2018
@aulneau aulneau moved this from Reviewer approved to Done in Launch App Mining Oct 17, 2018
@hstove hstove closed this as completed Oct 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

3 participants