Skip to content
This repository has been archived by the owner on Jan 6, 2023. It is now read-only.

Add SVG image acceptance to our image proxy service #391

Closed
GinaAbrams opened this issue Jan 4, 2019 · 4 comments
Closed

Add SVG image acceptance to our image proxy service #391

GinaAbrams opened this issue Jan 4, 2019 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@GinaAbrams
Copy link

I hope this is clear 😅

@cuevasm
Copy link
Collaborator

cuevasm commented Jan 4, 2019

I would actually suggest we don't accept SVG (if this is related to logos for the app pages), reason being the images get fed into email and is not supported in inboxes so it shows as broken.

@aulneau
Copy link
Contributor

aulneau commented Jan 4, 2019

We are using imgix which allows us to format the images after the fact as we wish. For example @cuevasm you can append format=png to the url and it will always be a png.

Add SVG image acceptance to our image proxy service

I'm not sure what you mean exactly @GinaAbrams :) could you clarify?

@GinaAbrams
Copy link
Author

Sure! Right now, SVG links are not being reflected on app.co/mining/apps (so their logos are not populating properly.) @hstove indicated today that we could potentially add SVG acceptance to the submission form if we indicate it as so on our proxy service? 🤔

@aulneau aulneau added the bug Something isn't working label Jan 14, 2019
@moxiegirl moxiegirl added this to the Sprint 1: Week 3-4 milestone Jan 14, 2019
@markmhendrickson
Copy link
Contributor

This issue will be resolved with hirosystems/app.co-api#1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants