fix: keychain tests failing in ci

hirosystems · Oct 14, 2020 · 0bc9d38 · 0bc9d38
1 parent df60924
commit 0bc9d38
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 16 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -7,7 +7,7 @@ jobs:
   build:
     docker:
       # specify the version you desire here
-      - image: circleci/node:12.16.3
+      - image: circleci/node:14.6.0
 
       # Specify service dependencies here if necessary
       # CircleCI maintains a library of pre-built images

diff --git a/packages/keychain/package.json b/packages/keychain/package.json
@@ -60,7 +60,7 @@
     "eslint": "^6.3.0",
     "eslint-plugin-jest": "^23.8.2",
     "jest": "^24.9.0",
-    "jest-fetch-mock": "^2.1.2",
+    "jest-fetch-mock": "^3.0.3",
     "npm-run-all": "^4.1.5",
     "shx": "^0.3.2",
     "ts-jest": "^26.4.1",

diff --git a/packages/keychain/tests/mnemonic/mnemonic.test.ts b/packages/keychain/tests/mnemonic/mnemonic.test.ts
@@ -23,7 +23,7 @@ describe('generateEncryptedMnemonicRootKeychain()', () => {
 
 describe('restoreKeychainFromMnemonic()', () => {
   test('it restores keychain from a seed', async () => {
-    const password = '6bd8106ff1704446ba11e31ff3b0ce8b';
+    // const password = '6bd8106ff1704446ba11e31ff3b0ce8b';
     const phrase =
       'eternal army wreck noodle click shock include orchard jungle only middle forget idle pulse give empower iron curtain silent blush blossom chef animal sphere';
 

diff --git a/packages/keychain/tests/utils.test.ts b/packages/keychain/tests/utils.test.ts
@@ -77,6 +77,7 @@ describe(validateSubdomainAvailability.name, () => {
     fetchMock.once(JSON.stringify({ success: true }));
     const response = await validateSubdomainAvailability('slkdjfskldjf', Subdomains.TEST);
     expect(response).toEqual({ success: true });
+    // @ts-ignore
     const url: string = fetchMock.mock.calls[0][0];
     expect(url.includes(registrars[Subdomains.TEST].apiUrl)).toBeTruthy();
   });

diff --git a/yarn.lock b/yarn.lock
@@ -8110,14 +8110,6 @@ jest-environment-node@^25.5.0:
     jest-util "^25.5.0"
     semver "^6.3.0"
 
-jest-fetch-mock@^2.1.2:
-  version "2.1.2"
-  resolved "https://registry.yarnpkg.com/jest-fetch-mock/-/jest-fetch-mock-2.1.2.tgz#1260b347918e3931c4ec743ceaf60433da661bd0"
-  integrity sha512-tcSR4Lh2bWLe1+0w/IwvNxeDocMI/6yIA2bijZ0fyWxC4kQ18lckQ1n7Yd40NKuisGmcGBRFPandRXrW/ti/Bw==
-  dependencies:
-    cross-fetch "^2.2.2"
-    promise-polyfill "^7.1.1"
-
 jest-fetch-mock@^3.0.3:
   version "3.0.3"
   resolved "https://registry.yarnpkg.com/jest-fetch-mock/-/jest-fetch-mock-3.0.3.tgz#31749c456ae27b8919d69824f1c2bd85fe0a1f3b"
@@ -10903,11 +10895,6 @@ promise-inflight@^1.0.1:
   resolved "https://registry.yarnpkg.com/promise-inflight/-/promise-inflight-1.0.1.tgz#98472870bf228132fcbdd868129bad12c3c029e3"
   integrity sha1-mEcocL8igTL8vdhoEputEsPAKeM=
 
-promise-polyfill@^7.1.1:
-  version "7.1.2"
-  resolved "https://registry.yarnpkg.com/promise-polyfill/-/promise-polyfill-7.1.2.tgz#ab05301d8c28536301622d69227632269a70ca3b"
-  integrity sha512-FuEc12/eKqqoRYIGBrUptCBRhobL19PS2U31vMNTfyck1FxPyMfgsXyW4Mav85y/ZN1hop3hOwRlUDok23oYfQ==
-
 promise-polyfill@^8.1.3:
   version "8.1.3"
   resolved "https://registry.yarnpkg.com/promise-polyfill/-/promise-polyfill-8.1.3.tgz#8c99b3cf53f3a91c68226ffde7bde81d7f904116"