Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BN.js type hacks #753

Merged
merged 1 commit into from Jan 16, 2020
Merged

Fix BN.js type hacks #753

merged 1 commit into from Jan 16, 2020

Conversation

zone117x
Copy link
Member

@zone117x zone117x commented Jan 4, 2020

Description

Closes #751

Fixes the BN.js type problems -- nows that the @types/bn.js package has been updated with DefinitelyTyped/DefinitelyTyped#41255

Downstream typescript dependencies no longer require skipLibCheck

Type of Change

  • New feature
  • Bug fix
  • API reference/documentation update
  • Other

Checklist

  • Code is commented where needed
  • Unit test coverage for new or modified code paths
  • npm run test passes
  • Changelog is updated
  • Tag 1 of @yknl or @zone117x for review

@zone117x zone117x requested a review from yknl January 4, 2020 00:18
@codecov
Copy link

codecov bot commented Jan 4, 2020

Codecov Report

Merging #753 into feature/content-length-checking will increase coverage by 0.02%.
The diff coverage is 88.46%.

Impacted file tree graph

@@                         Coverage Diff                         @@
##           feature/content-length-checking     #753      +/-   ##
===================================================================
+ Coverage                            68.72%   68.75%   +0.02%     
===================================================================
  Files                                   65       64       -1     
  Lines                                 3814     3808       -6     
  Branches                               692      693       +1     
===================================================================
- Hits                                  2621     2618       -3     
+ Misses                                 867      863       -4     
- Partials                               326      327       +1
Impacted Files Coverage Δ
src/operations/txbuild.ts 89.82% <ø> (ø) ⬆️
src/network.ts 75.06% <100%> (ø) ⬆️
src/operations/utils.ts 95.5% <100%> (ø) ⬆️
src/operations/skeletons.ts 79.48% <50%> (ø) ⬆️
src/encryption/ec.ts 84.67% <83.33%> (-3.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dedafa...2d821bc. Read the comment docs.

@zone117x zone117x changed the base branch from feature/content-length-checking to develop January 11, 2020 22:48
Copy link
Contributor

@yknl yknl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the bn.js PR in support of this too.

@zone117x zone117x merged commit 0728e0f into develop Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants