Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add execution cost data to transactions #737

Merged
merged 3 commits into from Sep 2, 2021
Merged

Conversation

rafaelcr
Copy link
Collaborator

@rafaelcr rafaelcr commented Sep 2, 2021

Description

This change captures execution cost data from raw node transactions and saves it as columns in the PostgreSQL txs table. It also exposes this new data to transaction API endpoints so users can see them.

Closes #734

Type of Change

  • New feature
  • Bug fix
  • API reference/documentation update
  • Other

Does this introduce a breaking change?

No

Are documentation updates required?

Only schema changes which will be automated into docs

Testing information

Covered by unit tests

Checklist

  • Code is commented where needed
  • Unit test coverage for new or modified code paths
  • npm run test passes
  • Changelog is updated
  • Tag 1 of @kyranjamie or @zone117x for review

@vercel
Copy link

vercel bot commented Sep 2, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/blockstack/stacks-blockchain-api/pvF97GRqukGKRwf3EJT6SdpAshfv
✅ Preview: https://stacks-blockchain-api-git-feat-execution-cost-data-blockstack.vercel.app

@codecov
Copy link

codecov bot commented Sep 2, 2021

Codecov Report

Merging #737 (fd64ee5) into develop (e37b5af) will increase coverage by 0.79%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #737      +/-   ##
===========================================
+ Coverage    65.52%   66.32%   +0.79%     
===========================================
  Files           79       87       +8     
  Lines         8049    10155    +2106     
  Branches      1257     1659     +402     
===========================================
+ Hits          5274     6735    +1461     
- Misses        2770     3414     +644     
- Partials         5        6       +1     
Impacted Files Coverage Δ
src/api/controllers/db-controller.ts 74.56% <ø> (ø)
src/datastore/common.ts 77.21% <ø> (-1.43%) ⬇️
src/event-stream/core-node-message.ts 94.44% <ø> (ø)
src/migrations/1584619633448_txs.ts 100.00% <ø> (ø)
src/datastore/postgres-store.ts 86.90% <100.00%> (+2.77%) ⬆️
src/index.ts 0.00% <0.00%> (ø)
src/tests-tokens/setup.ts 0.00% <0.00%> (ø)
src/migrations/1621511823381_nft-metadata.ts 100.00% <0.00%> (ø)
src/migrations/1621511832113_ft-metadata.ts 100.00% <0.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e37b5af...fd64ee5. Read the comment docs.

@rafaelcr rafaelcr linked an issue Sep 2, 2021 that may be closed by this pull request
Copy link
Member

@zone117x zone117x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick turnaround! LGTM!

@rafaelcr rafaelcr merged commit d9e1131 into develop Sep 2, 2021
@rafaelcr rafaelcr deleted the feat/execution-cost-data branch September 2, 2021 18:05
@blockstack-devops
Copy link

🎉 This PR is included in version 0.65.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Store & expose tx execution cost data
3 participants