Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax trait inference #1679

Merged
merged 3 commits into from
Jun 16, 2020
Merged

Relax trait inference #1679

merged 3 commits into from
Jun 16, 2020

Conversation

lgalabru
Copy link
Contributor

@lgalabru lgalabru commented Jun 15, 2020 •
edited
Loading

This PR is addressing #1621, by allowing trait inference when a principal is being passed (as a literal) to a user defined function.

@lgalabru lgalabru requested review from kantai and jcnelson June 15, 2020 19:47
@lgalabru lgalabru self-assigned this Jun 16, 2020
@psq
Copy link
Contributor

psq commented Jun 16, 2020

thanks for fixing, @lgalabru !

kantai
kantai approved these changes Jun 16, 2020
View reviewed changes
Copy link
Member

@kantai kantai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, @lgalabru -- though you should change the _binded_ test name to _bound_.

@jcnelson jcnelson self-requested a review June 16, 2020 15:23
@lgalabru lgalabru merged commit f6c882e into master Jun 16, 2020
@lgalabru lgalabru deleted the fix/pass-trait-user-functions branch June 16, 2020 17:40
@lgalabru lgalabru mentioned this pull request Jun 16, 2020
Closed
@psq psq mentioned this pull request Aug 19, 2020
Merged
@njordhov njordhov mentioned this pull request Aug 20, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psq psq psq left review comments

@jcnelson jcnelson jcnelson approved these changes

@kantai kantai kantai approved these changes

Assignees

@lgalabru lgalabru

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lgalabru @psq @jcnelson @kantai