Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/testnet thread debugging fixes #1714

Merged
merged 3 commits into from
Jul 6, 2020

Conversation

jcnelson
Copy link
Member

@jcnelson jcnelson commented Jul 6, 2020

Recently, the Argon master node's p2p thread stalled. It did not die -- it still held open the channel linking it to the relayer thread, and it still held the sockets -- but it stopped looping. This PR does the following:

  • Sets a panic handler to force the process to abort on thread panic
  • Adds better-placed debug messages to the top-level p2p dispatcher, so we can see that the p2p dispatcher is doing something
  • Adds better-placed debug messages to the top-level p2p thread and relay thread, so we can see that they are still alive

@jcnelson jcnelson requested review from lgalabru and kantai July 6, 2020 04:36
Copy link
Contributor

@lgalabru lgalabru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Member

@kantai kantai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lgalabru lgalabru merged commit a369219 into master Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants