Krypton deployment + adjustments #1896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcnelson
reviewed
Sep 21, 2020
| 120, | ||
| 30, | ||
| 20, | ||
| 3333333333333333) // total liquid supply is 40000000000000000 µSTX |
There was a problem hiding this comment.
So, 8.3% of liquid uSTX can disable PoX?
There was a problem hiding this comment.
Am I misunderstanding #1882?
There was a problem hiding this comment.
8.3% is fine by me -- I'm in favor of a low threshold so the community can easily test it out. I was just curious if there was a particular reason for the precise number.
There was a problem hiding this comment.
Yep, 8.3% works for me -- if someone griefs the PoX anchor blocks, we can always bump it up
jcnelson
approved these changes
Sep 21, 2020
lgalabru
force-pushed
the
release/krypton
branch
from
8dc4f24
to
d6049d0
Compare
muneeb-ali
reviewed
Sep 22, 2020
| @@ -934,9 +934,9 @@ impl PeerHost { | |||
| #[derive(Debug, Clone, PartialEq, Serialize, Deserialize)] | |||
| pub struct RPCPeerInfoData { | |||
| pub peer_version: u32, | |||
| pub burn_consensus: ConsensusHash, | |||
| pub pox_consensus: ConsensusHash, | |||
There was a problem hiding this comment.
pox_consensus makes sense here 👍
This was referenced Sep 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional adjustments: