-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: show stx transfers from contract call #1747
Conversation
🦋 Changeset detectedLatest commit: 9732c97 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/blockstack/stacks-wallet-web/4jxXmYENwEHUxxaHxSWT3uCueCc8 |
4c23d34
to
4cde18f
Compare
4cde18f
to
794af4d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we can replace use of the This way, we could avoid adding a new query, and any logic to try and merge transactions together. Instead updating the store to save the different response type (which includes the whole tx in addition to the transfers). |
b98afae
to
1bca928
Compare
1bca928
to
c6b3533
Compare
c6b3533
to
be7886c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a much better approach, thanks @beguene—
I have many comments, but these are mostly around naming
src/common/hooks/account/use-account-transactions-with-transfers.hooks.ts
Outdated
Show resolved
Hide resolved
src/common/hooks/account/use-account-transactions-with-transfers.hooks.ts
Outdated
Show resolved
Hide resolved
src/common/hooks/account/use-account-transactions-with-transfers.hooks.ts
Outdated
Show resolved
Hide resolved
bb5a09f
to
30fec97
Compare
30fec97
to
d9a7430
Compare
d9a7430
to
f8a3a86
Compare
src/common/hooks/account/use-account-transactions-with-transfers.hooks.ts
Outdated
Show resolved
Hide resolved
src/common/hooks/account/use-account-transactions-with-transfers.hooks.ts
Outdated
Show resolved
Hide resolved
3276f20
to
8cc6ceb
Compare
@Eshwari007 @timstackblock This is ready for QA. It fixes issue #1432 and #1460 (for stx transfers) and #1713 for token transfers. A lot has changed in the activity list, so you can focus your test around that area. |
@beguene Will test and keep you posted on my findings. |
8cc6ceb
to
69bcfb2
Compare
69bcfb2
to
7249c61
Compare
7249c61
to
9732c97
Compare
e9a0083
to
934be6a
Compare
Fixes #1713.
Shows all internal STX transfers triggered within contracts.
Those transfers txs are reconstructed from the contract events info and fetched from the api endpoint /transactions_with_transfers
and then merged with existing confirmed transactions. Those STX transfers are sorted to appear after the contract call (above the contract call row in the activity list)
cc/ @aulneau @kyranjamie @fbwoolf