[Canary] Alpha release #936

hstove · 2021-01-29T22:08:28Z

Try out this version of the Stacks Wallet - download extension builds or the Stacks testnet demo app

To decrease the confusion around having multiple open PRs for the Stacks Wallet for Web release, this single PR can be treated as the official "canary" release branch.

NPM tags will be set to "canary" for Connect packages. Builds from this PR will be deployed to the web wallet install page.

kyranjamie · 2021-02-17T09:54:20Z

.github/workflows/version.yml

-          name: connect-extension
-          path: connect-extension.zip
+          name: stacks-wallet-chromium
+          path: stacks-wallet-chromium.zip


version number in filename?

This file is then uploaded to GCS, which is how it's downloaded from hiro.so. We'd have to duplicate the .zip and then upload the version without a filename.

There is more work required to update our actual production flows, because right now it's quite tied to the app.blockstack.org production flow. I'm going to table this, it's a good suggestion, but I'd rather combine it with other CI work.

kyranjamie · 2021-02-17T09:55:16Z

packages/app/src/common/api/accounts.ts

+import { fetchPendingTxs } from '@common/api/transactions';
+import { fetchFromSidecar } from '@common/api/fetch';
+
+export const fetchBalances = (apiServer: string) => (


Could also use the generated client, I'm hybrid-using it in a wrapper

kyranjamie · 2021-02-17T09:56:47Z

packages/app/src/common/dev/types/globals.d.ts

@@ -2,3 +2,6 @@ declare const EXT_ENV: string;
 declare const NODE_ENV: string;
 declare const SEGMENT_KEY: string;
 declare const STATS_URL: string;
+declare const COMMIT_SHA: string;
+declare const VERSION: string;
+declare const BRANCH: string;


Personal pref would be to have all these in a single global object, just for dev x of seeing them in the autocomplete

kyranjamie · 2021-02-17T09:57:30Z

packages/app/src/common/hooks/use-message-pong.ts

@@ -1,28 +1,26 @@
 import { useEffect, useCallback } from 'react';
-import { useSelector } from 'react-redux';
-import { selectAuthRequest } from '@store/onboarding/selectors';
+// import { useSelector } from 'react-redux';


kyranjamie · 2021-02-17T10:02:03Z

packages/app/src/common/hooks/use-setup-tx.ts

+        const newConditions: PostCondition[] = payload.postConditions.map(postCondition => {
+          let newCondition: PostCondition;
+          if (typeof postCondition === 'string') {
+            const reader = BufferReader.fromBuffer(Buffer.from(postCondition, 'hex'));
+            newCondition = deserializePostCondition(reader);
+          } else {
+            newCondition = { ...postCondition };
+          }
+          // override principal with current user
+          newCondition = {
+            ...newCondition,
+            principal: parsePrincipalString(currentAddress),
+          };
+          return newCondition;
+        });
+        set(postConditionsStore, newConditions);
+      }


Nit pick, but this is kinda mixing programming styles imo. Mapping an array, functional, then reassigning a ref, imperative. No action needed, just an observation that it'd look cleaner with a const lol.

kyranjamie · 2021-02-17T10:37:12Z

packages/app/src/components/popup/token-assets.tsx

+      {currentNetworkKey === 'mainnet' ? (
+        <Text
+          as="a"
+          href="https://coinmarketcap.com/currencies/blockstack/markets/"


I've been putting all external urls in a constants file

kyranjamie · 2021-02-17T10:37:40Z

packages/app/src/components/popup/token-assets.tsx

+  const fungibleTokens = Object.keys(balances.fungible_tokens).map(key => {
+    const token = balances.fungible_tokens[key];
+    const friendlyName = key.split('::')[1];
+    return (


Think I've seen logic like this earlier, util fn?

kyranjamie · 2021-02-17T10:37:55Z

packages/app/src/components/popup/token-assets.tsx

+        friendlyName={friendlyName}
+        key={key}
+        value={token.balance}
+        subtitle={friendlyName.slice(0, 3).toUpperCase()}


Definitely seen this slice before, also a util fn here

Ultimately all of this is a smell that we need to remove at the design level. It needs to be data that's pulled from the token itself, or simply not have a "ticker" at all. These values don't mean anything

kyranjamie · 2021-02-17T10:38:36Z

packages/app/src/components/popup/tx-item.tsx

+
+const getTxLabel = (tx: Tx): string => {
+  if (tx.tx_type === 'token_transfer') return 'Stacks Transfer';
+  if (tx.tx_status === 'pending') return 'Pending Transaction';


if you have a pending tx token transfer it won't ever get here

That is a very good catch

kyranjamie · 2021-02-17T10:40:02Z

packages/app/src/components/popup/tx-item.tsx

+
+type Tx = MempoolTransaction | Transaction;
+
+const getAssetTransfer = (tx: Tx): TransactionEventFungibleAsset | undefined => {


Mixing between error case returning null or undefined. I'm a null man, myself. I've seen others advocating sticking to undefined. Either way, consistency 👍🏼

kyranjamie · 2021-02-17T10:47:25Z

80% style/convention/preference comments, and would encourage for an interactive rebase to squash some of unneeded commits.

Otherwise it's looking pretty good. I'd advocate making more separate layout/styling components. When all the logic & styling is in the same component, core functionality gets lots in amongst the styling props etc.

aulneau · 2021-02-18T14:03:38Z

.github/workflows/version.yml

-          name: connect-extension
-          path: connect-extension.zip
+          name: stacks-wallet-chromium
+          path: stacks-wallet-chromium.zip


aulneau · 2021-02-18T14:04:23Z

packages/app/.eslintrc.js

+    '@typescript-eslint/no-unsafe-assignment': [0],
+    '@typescript-eslint/no-unsafe-return': [0],
+    '@typescript-eslint/no-unsafe-call': [0],
+    '@typescript-eslint/no-unsafe-member-access': [0],
+    '@typescript-eslint/ban-types': [0],
+    '@typescript-eslint/restrict-template-expressions': [0],
+    '@typescript-eslint/explicit-module-boundary-types': [0],
+    "no-warning-comments": [1],
+    "react-hooks/exhaustive-deps": [
+      "warn", {
+        additionalHooks: "useRecoilCallback",
+      },
+    ]


Should we add these to @stacks/eslint-config?

Hm, I'm not sure. Some you could argue are better left enabled, and anything React should be an extended config, or something.

aulneau · 2021-02-18T14:06:00Z

packages/app/src/common/hooks/use-account-info.ts

+import { useLoadable } from './use-loadable';
+
+export const useFetchAccountData = () => {
+  const accountData = useLoadable(accountDataStore);


Suggested change

const accountData = useLoadable(accountDataStore);

return useLoadable(accountDataStore);

aulneau · 2021-02-18T14:06:10Z

packages/app/src/common/hooks/use-account-info.ts

+};
+
+export const useFetchBalances = () => {
+  const accountBalances = useLoadable(accountBalancesStore);


Suggested change

const accountBalances = useLoadable(accountBalancesStore);

return useLoadable(accountBalancesStore);

aulneau · 2021-02-18T14:06:42Z

packages/app/src/common/hooks/use-color-mode.ts

+    document.documentElement.classList.add('dark');
+    document.documentElement.classList.remove('light');
+    setHtmlBackgroundColor();
+  }, []);


Suggested change

}, []);

}, [setHtmlBackgroundColor]);

aulneau · 2021-02-18T14:13:15Z

packages/app/src/components/accounts/index.tsx

  return (
    <Flex alignItems="center" maxWidth="100%" {...rest}>
-      <Flex flex={1} maxWidth="100%">
+      <Flex flex={1} maxWidth="100%" dir="column">


Suggested change

<Flex flex={1} maxWidth="100%" dir="column">

<Flex flex={1} maxWidth="100%" flexDirection="column">

aulneau · 2021-02-18T14:16:04Z

packages/app/src/components/css-reset.tsx

+});
+const { color, bg, borderColor, placeholderColor } = defaultConfig(theme).light;
+
+const cssReset = css`


yeah we should be able to use the one from @stacks/ui

aulneau · 2021-02-18T14:17:59Z

packages/app/src/components/popup/asset-list.tsx

+  const TabHeader: React.FC<{ tab: Tab }> = ({ tab }) => {
+    const tabName = new String(tab);
+    return (
+      <Box
+        width="50%"
+        textAlign="center"
+        p="base-tight"
+        cursor="pointer"
+        fontSize="14px"
+        {...getTabStyles(tab)}
+        onClick={() => setCurrentTab(tab)}
+      >
+        <Text fontSize={2}>{tabName.charAt(0).toUpperCase() + tabName.slice(1)}</Text>
+      </Box>
+    );
+  };


ideally not

aulneau · 2021-02-18T14:18:34Z

packages/app/src/components/popup/container.tsx

+  const Settings: React.FC<BoxProps> = props => {
+    if (hideActions) return null;
+    return (
+      <IconButton
+        size="42px"
+        iconSize="24px"
+        onClick={() => setShowSettings(true)}
+        color="black"
+        icon={IconMenu2}
+        {...props}
+      />
+    );
+  };


should take this out into its own. v bad perf

aulneau · 2021-02-18T14:19:16Z

packages/app/src/components/popup/settings-popover.tsx

+  </Box>
+);
+
+export const SettingsPopover: React.FC = () => {


yeah -> https://material-ui.com/components/popover/

hstove · 2021-03-08T19:04:11Z

Woohoo! We can close this, since the code in this branch has been pushed directly to the main branch, which is our new default branch.

blockstack-devops and others added 30 commits January 9, 2021 12:35

feat: stacks wallet for web

6957c04

fix: yarn.lock

5b0a745

fix: add ability to view secret key

d7dca7d

feat: disable username registrations

1f21428

feat: refactor wallet logic, remove keychain

0f3ac1f

fix: broken extension locked state, fixes #760

c2bca4e

feat: stacks wallet branding, icon, asset cleanup, fixes #732

b9cb445

fix: choose account page tweaks, fixes #735

6ae6889

fix: bug when creating new account

7bdeec6

fix: cursor on settings popover, fixes #739

8d58259

fix: stacks blockchain api language, fixes #740

2a3a6f9

feat: password validation, fixes #733, fixes #720

d8f6832

fix: linting error

35ca002

fix: header alignment

7121f8a

fix: authentication error

6abf504

fix: testnet demo bug, fixes #774

e9ac21a

fix: secret key cut off, 24 words default, fixes #771

0f27637

fix: nasty bugs around password, redux state in ext, fixes #770

6fc81dd

fix: syntax for checking stable branch

a88ce5d

feat: upload stable builds from launch-misc

4fed3e2

fix: integration tests

c903de7

feat: restore from wallet config

008b1a2

feat: qol improvements for tx signing

f86d568

fix: wonky url causing issues in auth

fba1619

feat: improved UX around wallet onboarding

8ab3dd3

fix: tests with new auth rules

6934049

fix: showing connect ui and opening extension

f1f75de

fix: header on demo app

e2969c8

fix: spacing, flow of sign up

d514fd4

fix: capitalize secret key, fixes #768

0706230

markmhendrickson added this to the Merge alpha canary milestone Feb 3, 2021

hstove mentioned this pull request Feb 3, 2021

Extension allows me to send STX to a test address from the mainnet (this transaction is not broadcast) #945

Closed

friedger mentioned this pull request Feb 6, 2021

Problem with contract transactions after the testnet api endpoint upgrade. hirosystems/stacks.js#942

Closed

hstove added 5 commits February 10, 2021 08:08

fix: link packages when building in npm

34aff46

feat: move key management to 'vault' in background script

b83cc7e

chore: remove inactivity lock

3c8e7ab

fix: revert to localStorage for ext, fix CI oddities

e43b74d

fix: track rehydrated from vault to reduce jitter on load

8d76df9

markmhendrickson mentioned this pull request Feb 16, 2021

Design QA alpha release #975

Closed

kyranjamie reviewed Feb 17, 2021

View reviewed changes

aulneau reviewed Feb 18, 2021

View reviewed changes

hstove force-pushed the release/canary branch from fea675d to 7a54f54 Compare February 18, 2021 23:46

fix: improvements from code review feedback

2a1d243

hstove force-pushed the release/canary branch from 7a54f54 to 2a1d243 Compare February 19, 2021 00:22

andresgalante assigned hstove Feb 19, 2021

aulneau and others added 4 commits February 25, 2021 13:11

fix: small csp fix

1306198

fix: conditional bug

5f2ad4a

fix: nonce issue

225e1f3

chore: add header to all requests

b2470a5

hstove mentioned this pull request Mar 2, 2021

Modify CI and branches for Web Wallet alpha release #1043

Closed

7 tasks

hstove linked an issue Mar 5, 2021 that may be closed by this pull request

Modify CI and branches for Web Wallet alpha release #1043

Closed

7 tasks

hstove force-pushed the release/canary branch from b431ec1 to b2470a5 Compare March 5, 2021 01:50

feat: move production extension publishing to "publish" workflow

e354d54

hstove closed this Mar 8, 2021

kyranjamie deleted the release/canary branch June 14, 2021 12:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Canary] Alpha release #936

[Canary] Alpha release #936

hstove commented Jan 29, 2021 •

edited by github-actions bot

Loading

kyranjamie Feb 17, 2021

aulneau Feb 18, 2021

hstove Feb 18, 2021

kyranjamie Feb 17, 2021

kyranjamie Feb 17, 2021

kyranjamie Feb 17, 2021

kyranjamie Feb 17, 2021

kyranjamie Feb 17, 2021

kyranjamie Feb 17, 2021

kyranjamie Feb 17, 2021

hstove Feb 18, 2021

kyranjamie Feb 17, 2021

hstove Feb 18, 2021

kyranjamie Feb 17, 2021

kyranjamie commented Feb 17, 2021

aulneau Feb 18, 2021

aulneau Feb 18, 2021

hstove Feb 18, 2021

aulneau Feb 18, 2021

aulneau Feb 18, 2021

aulneau Feb 18, 2021

aulneau Feb 18, 2021

aulneau Feb 18, 2021

aulneau Feb 18, 2021

aulneau Feb 18, 2021

aulneau Feb 18, 2021

hstove commented Mar 8, 2021


		type Tx = MempoolTransaction \| Transaction;

		const getAssetTransfer = (tx: Tx): TransactionEventFungibleAsset \| undefined => {

	const accountData = useLoadable(accountDataStore);
	return useLoadable(accountDataStore);

	const accountBalances = useLoadable(accountBalancesStore);
	return useLoadable(accountBalancesStore);

	<Flex flex={1} maxWidth="100%" dir="column">
	<Flex flex={1} maxWidth="100%" flexDirection="column">

[Canary] Alpha release #936

[Canary] Alpha release #936

Conversation

hstove commented Jan 29, 2021 • edited by github-actions bot Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kyranjamie commented Feb 17, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hstove commented Mar 8, 2021

hstove commented Jan 29, 2021 •

edited by github-actions bot

Loading