Settling Perp PnL on an account before we liquidate perp and token #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is good, but I think it'd be more efficient to use the settlePosPnl function on |
Thanks for the pointer, @dafyddd. To confirm: on the settlePosPnl function, is |
This is an optimization on f97370f following Dafy's suggestion here: blockworks-foundation#17 (comment) It uses the client's settlePosPnl function instead of doing all the work itself. It required making the mangoAccounts array global so we can have access to it when liquidating from the RPC endpoint, but I'm not getting any movement from the feed anyway.
ricardojmendez
force-pushed
the
settling-perp-pnl
branch
from
b89fef0
to
6655afe
Compare
|
Hi @ricardojmendez, thanks for this. The settlePosPnl function is in a later mango-client version so I will upgrade. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we may end up with token liquidations of value 0. See this post by Daffy
To be frank, I'm not sure if this is the right point to do it at, but thought I'd contribute it just in case.