Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix,379 identity key pair loading must be optional #381

Merged
merged 3 commits into from
Apr 2, 2024
Merged

Bugfix,379 identity key pair loading must be optional #381

merged 3 commits into from
Apr 2, 2024

Conversation

grooviegermanikus
Copy link
Collaborator

@grooviegermanikus grooviegermanikus commented Apr 2, 2024 •
edited
Loading

fixes #379

note: also affects non-proxy part as precedence between loading from ENV and cli gets changed:

  1. check if env variable IDENTITY is present
  2. check if cli arg --identity-keypair is present
  3. assume no identity

@grooviegermanikus grooviegermanikus merged commit 944a931 into main Apr 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godmodegalactus godmodegalactus godmodegalactus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

config error in load_identity_keypair - Cannot find the identity file provided
2 participants
@grooviegermanikus @godmodegalactus