Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gixing websocket subscriptions for signatures and slot #403

Merged
merged 3 commits into from
Jun 28, 2024

Conversation

godmodegalactus
Copy link
Collaborator

@godmodegalactus godmodegalactus commented Jun 26, 2024

Updating signatures for few methods,
Fixing websockets signatures.
Removing unwanted tests

@@ -18,7 +18,7 @@ solana-sdk = { workspace = true }
solana-streamer = { workspace = true }
solana-transaction-status = { workspace = true }
solana-net-utils = { workspace = true }
rustls = { workspace = true, features = ["dangerous_configuration"]}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you remove that?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed.

@@ -24,19 +24,61 @@ function createTransaction(): Transaction {
return transaction;
}

// test('send and confrim with websockets', async () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is that commented code?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will remove it

expect(Object.keys(leaderSchedule).length > 0);
}
});
// test('get epoch info', async () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commented code - decide what to do with it

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed really

@godmodegalactus godmodegalactus changed the title Updating send transaction method signature Gixing websocket subscriptions for signatures and slot Jun 28, 2024
@godmodegalactus godmodegalactus merged commit 129d6a8 into main Jun 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants