Update nodegit to version 0.17.0 🚀 #101
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello lovely humans,
nodegit just published its new version 0.17.0.
This version is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of nodegit.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?
There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.
Good luck with your project ✨
You rock!
🌴
GitHub Release
Targeted Platform Changes
In this release we had added support for Node v7 and latest Electron. We have removed support for Node v0.12 and v5.
We are also deprecating nw.js support since it is currently broken, no one in the current team uses it and we would not be able to currently support nw.js in an effective manner with a good user experience.
Now building against shared libcurl lib
For proxy support we now use libcurl for HTTP/HTTPS transport which should have no noticeable change in NodeGit remote operations but if changes are noticed this is worth mentioning as a potential source.
Memory leak fixes and stability increases
Many PR's were made to fix memory leaks as they were found so memory usage should go down in this version for long running scripts. Additionally, when performing operations with callbacks (transfer progress, credentials, etc...) there was a small chance for a segfault when NodeGit would schedule the callback to go into JavaScript. This is now fixed.
Fixes to the build
Many users, especially on windows, were experiencing errors during the build. The build still isn't perfect but a lot of the bugs were fixed.
Bump libgit2 to 0bf0526
The majority of changes to NodeGit v17 were in libgit2. The API breaking changes that are known are:
RevWalk
is returning different results libgit2 PR #3921Summary of changes that were brought in:
#1187 (comment)
Changes to NodeGit outside of libgit2 bump
Tree#getEntry
PR #1178Repository#createBranch
docs PR #1198lookup
anddwim
in Reference PR #1203The new version differs by 79 commits .
248afda
Add header to separate v0.17 libgit2 changes vs NodeGit specific changes
b894ccf
Bump to v0.17
5d807eb
Update changelog for v0.16.0
4a93dbf
Merge pull request #1195 from implausible/feature/enable-curl-support
3828c83
Merge pull request #1197 from srajko/uv_close-fix
be4b356
Merge pull request #1187 from srajko/bump-libgit
6d7762b
Unreference handle to allow node to terminate
3db424e
Bump libgit to 0bf0526
45ce97d
Allow both types of failures for invalid credentials test
acb6c41
Remove sleep_for_ms
884900f
Allocate baton on stack
c0c383f
Use ExecuteReverseCallback
9c01821
Add support for reverse callbacks to ThreadPool
3e06530
Merge pull request #1203 from rcjsuen/patch-2
e359ca5
Merge pull request #1205 from rcjsuen/merge-cleanly
There are 79 commits in total. See the full diff.
Screencast
Try it today. Free for private repositories during beta.