adding simple validation checks to reggie client #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add basic checks to validate the client config, along with brief notes for development in the README to close #24. We discussed checking for an empty UserAgent, but it looks like this isn't possible (at least when called in the NewClient function). I tried various tricks to instantiate the client for the test and then change the UserAgent to an empty string, but always got memory / reference errors. So if it's not possible, we might just remove it. If it's possible, I'd want to know how and then adjust the test.
Signed-off-by: vsoch vsochat@stanford.edu