Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show for which tuning the chord diagrams are #60

Open
Louis-coding-UGNG opened this issue Aug 14, 2019 · 3 comments
Open

Show for which tuning the chord diagrams are #60

Louis-coding-UGNG opened this issue Aug 14, 2019 · 3 comments

Comments

@Louis-coding-UGNG
Copy link
Contributor

Louis-coding-UGNG commented Aug 14, 2019

Another feature request of the "nice to have" kind:

Whenever chord diagrams are shown the footer (song_editable.php) should mention the currently selected tuning standard GCEA or baritone DGBE (in the current language) just to avoid the least bit of confusion.
With no diagrams on screen this hint is unnecessary (in fact useless).
And of course this should update when the tuning is changed.

I know this has been removed in a previous commit, but thinking about it I'd like to have it back...

@bloodybowlers
Copy link
Owner

We could show the tuning everytime in the header, near key/tempo/capo.

Currently, we neeed a better way to display the key/tempo/capo/tuning info. When I say "better" I mean, visually. I don't know how and where to display those "secondary", but interesting nonetheless, informations. It needs to take as little space as possible, not cluttering the page, but being there anyway. Footer is not ideal, too far away...

Any ideas ?

@Louis-coding-UGNG
Copy link
Contributor Author

Louis-coding-UGNG commented Aug 15, 2019

Tuning info could be some kind of box title/header next to the chord diagrams (somewhere like top left corner of the aside id="ukeChordsCanvas")

The rest could go into a kind of comment box before the song text (with a possibility to make that "box" invisible) on the song-editable page, right after <article id="ukeSongText" class="ugs-source-wrap">. (font size ~80% should be enough)

On the songbook index the metadata (without tuning) could go into an additional line similar to the album info in the original UkeGeeks

@Louis-coding-UGNG
Copy link
Contributor Author

On the songbook index the metadata (without tuning) could go into an additional line similar to the album info in the original UkeGeeks

This is covered at least for subtitle and album in PR #72

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants