-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small display problem in the listing by artist #77
Comments
Have you modified the function code somehow?
|
I modify the code a little to fit my needs but when I was going bad, I copy/paste the exact same code from github. I don't understand. |
Nor do I :) |
Louis-coding-UGNG
added a commit
to Louis-coding-UGNG/UkeGeeks-ng
that referenced
this issue
Feb 29, 2020
fix bloodybowlers#77: wrongly nested div tags in Songlist by Artist
Closed
Louis-coding-UGNG
added a commit
to Louis-coding-UGNG/UkeGeeks-ng
that referenced
this issue
Feb 29, 2020
fix the wrongly nested div mentioned in bloodybowlers#77
Louis-coding-UGNG
added a commit
to Louis-coding-UGNG/UkeGeeks-ng
that referenced
this issue
Feb 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello and great thanks for this application, I'm from Tahiti and I'm working on my Ukulele Songbook here :
http://play.weloveukulele.com/songbook/, first design, then fill it with lots of songs so that we could enjoy music :)
I was first impressed by Uke-geeks but did not managed to make it work simply, and then I saw your fork and Wow !!! very very nice improvements, everything worked very easy to install. Thanks a lot.
I would like to be helped for this little problem with this function 'BuildSongListByArtist' , I'm sorry but I could not managed to fix the 'foreach' loop myself.
I noticed that the loop produces wrong nested elements as shown in the screenshot attached. (The first .SongListLetter div wraps all other divs and the other .SongListLetter div's are inside the last UL element of .SongListArtist)
Is it possible to solve this in order to have this result :
.SongListLetter
.SongListArtist
UL
LI
LI
LI
.SongListArtist
UL
LI
LI
.SongListArtist
UL
LI
.SongListLetter
.SongListArtist
UL
LI
LI
LI
.SongListArtist
UL
LI
LI
.SongListArtist
UL
LI
.SongListLetter
.SongListArtist
UL
LI
LI
LI
.SongListArtist
UL
LI
LI
.SongListArtist
UL
LI
Thank you a lot.
The text was updated successfully, but these errors were encountered: