Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small display problem in the listing by artist #77

Open
moana-digital opened this issue Feb 28, 2020 · 4 comments
Open

Small display problem in the listing by artist #77

moana-digital opened this issue Feb 28, 2020 · 4 comments

Comments

@moana-digital
Copy link

Hello and great thanks for this application, I'm from Tahiti and I'm working on my Ukulele Songbook here :
http://play.weloveukulele.com/songbook/, first design, then fill it with lots of songs so that we could enjoy music :)

I was first impressed by Uke-geeks but did not managed to make it work simply, and then I saw your fork and Wow !!! very very nice improvements, everything worked very easy to install. Thanks a lot.

I would like to be helped for this little problem with this function 'BuildSongListByArtist' , I'm sorry but I could not managed to fix the 'foreach' loop myself.
I noticed that the loop produces wrong nested elements as shown in the screenshot attached. (The first .SongListLetter div wraps all other divs and the other .SongListLetter div's are inside the last UL element of .SongListArtist)

Capture d’écran 2020-02-27 à 16 13 02

Is it possible to solve this in order to have this result :
.SongListLetter
.SongListArtist
UL
LI
LI
LI
.SongListArtist
UL
LI
LI
.SongListArtist
UL
LI
.SongListLetter
.SongListArtist
UL
LI
LI
LI
.SongListArtist
UL
LI
LI
.SongListArtist
UL
LI
.SongListLetter
.SongListArtist
UL
LI
LI
LI
.SongListArtist
UL
LI
LI
.SongListArtist
UL
LI

Thank you a lot.

@Louis-coding-UGNG
Copy link
Contributor

Have you modified the function code somehow?
The original code closes the div immediately after the letter:

echo "<div class='SongListLetter'>".strtoupper($currentLetter)."</div>";

@moana-digital
Copy link
Author

I modify the code a little to fit my needs but when I was going bad, I copy/paste the exact same code from github. I don't understand.

@Louis-coding-UGNG
Copy link
Contributor

Nor do I :)
But it seems to work now, I just visited your site and found correctly nested div (at least at first sight)

@moana-digital
Copy link
Author

No still not working well.
Look at screenshot: in red the wrong nested elements, in green what I'm searching for.
Capture d’écran 2020-02-28 à 11 28 29

Louis-coding-UGNG added a commit to Louis-coding-UGNG/UkeGeeks-ng that referenced this issue Feb 29, 2020
fix bloodybowlers#77: wrongly nested div tags in Songlist by Artist
Louis-coding-UGNG added a commit to Louis-coding-UGNG/UkeGeeks-ng that referenced this issue Feb 29, 2020
fix the wrongly nested div mentioned in bloodybowlers#77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants