Skip to content

Commit

Permalink
aside cleanup and log removal
Browse files Browse the repository at this point in the history
  • Loading branch information
seanmalbert committed Jun 24, 2021
1 parent 248e1e5 commit 831ceba
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 5 deletions.
1 change: 0 additions & 1 deletion backend/core/src/listings/listings.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ export class ListingsService {

public async list(jsonpath?: string, filter?: ListingFilterParams[]): Promise<Listing[]> {
const qb = this.getQueryBuilder()
console.log("***** filter ****** ", filter)
if (filter) {
addFilter<ListingFilterParams>(filter, "listings", qb)
}
Expand Down
2 changes: 1 addition & 1 deletion backend/core/src/shared/default-validation-pipe-options.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@ export const defaultValidationPipeOptions: ValidationPipeOptions = {
enableImplicitConversion: false,
},
groups: [ValidationsGroupsEnum.default],
forbidUnknownValues: false,
forbidUnknownValues: true,
}
9 changes: 6 additions & 3 deletions sites/partners/src/listings/Aside.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ const Aside = ({ type, setStatusAndSubmit }: AsideProps) => {

const cancel = (
<GridCell className="flex" key="btn-cancel">
<LinkButton unstyled fullWidth className="bg-opacity-0" href="/">
<LinkButton unstyled fullWidth className="bg-opacity-0" href={`/listings/${listingId}`}>
{t("t.cancel")}
</LinkButton>
</GridCell>
Expand Down Expand Up @@ -87,11 +87,14 @@ const Aside = ({ type, setStatusAndSubmit }: AsideProps) => {
{t("listings.actions.preview")}
</Button>
</a>
</GridCell>,
cancel
</GridCell>
)
}

if (type === "add" || type === "edit") {
elements.push(cancel)
}

return elements
}, [listingId, setStatusAndSubmit, type])

Expand Down

0 comments on commit 831ceba

Please sign in to comment.