Skip to content

Commit

Permalink
Merge branch 'add-storybook-a11y-testing-#142' of https://github.com/…
Browse files Browse the repository at this point in the history
…Exygy/bloom into add-storybook-a11y-testing-#142
  • Loading branch information
akegan committed Jul 8, 2021
2 parents 53c3f81 + 3aefec2 commit df701ea
Show file tree
Hide file tree
Showing 5 changed files with 33 additions and 31 deletions.
12 changes: 6 additions & 6 deletions ui-components/.storybook/preview.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,10 @@ export const parameters = {
rules: [
// TODO: Enable color-contrast after resolving #1488
{
id: 'color-contrast',
enabled: false
}
]
}
}
id: "color-contrast",
enabled: false,
},
],
},
},
}
4 changes: 3 additions & 1 deletion ui-components/__tests__/blocks/ImageCard.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@ describe("<ImageCard>", () => {
href="/listings"
/>
)
expect(getByAltText("A picture of the building").closest("a")?.getAttribute("href")).toBe("/listings")
expect(getByAltText("A picture of the building").closest("a")?.getAttribute("href")).toBe(
"/listings"
)
})
it("renders with an application status bar", () => {
const { getByText } = render(
Expand Down
14 changes: 7 additions & 7 deletions ui-components/src/actions/Button.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -132,10 +132,10 @@ inaccessible.parameters = {
config: {
rules: [
{
id: 'color-contrast',
enabled: false
}
]
}
}
}
id: "color-contrast",
enabled: false,
},
],
},
},
}
32 changes: 16 additions & 16 deletions ui-components/src/navigation/TabNav.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -24,16 +24,16 @@ Default.parameters = {
config: {
rules: [
{
id: 'no-focusable-content',
enabled: false
id: "no-focusable-content",
enabled: false,
},
{
id: 'nested-interactive',
enabled: false
}
]
}
}
id: "nested-interactive",
enabled: false,
},
],
},
},
}

export const Other = () => {
Expand All @@ -55,14 +55,14 @@ Other.parameters = {
config: {
rules: [
{
id: 'no-focusable-content',
enabled: false
id: "no-focusable-content",
enabled: false,
},
{
id: 'nested-interactive',
enabled: false
}
]
}
}
id: "nested-interactive",
enabled: false,
},
],
},
},
}
2 changes: 1 addition & 1 deletion ui-components/src/tables/StandardTable.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ dataWithImage[0].image = (
)
dataWithImage[1].image = (
<TableThumbnail>
<img src="/images/logo_glyph.svg" alt="logo"/>
<img src="/images/logo_glyph.svg" alt="logo" />
</TableThumbnail>
)

Expand Down

0 comments on commit df701ea

Please sign in to comment.